* [PATCH]wireless:ath9k Fix ath_print in xmit.c
@ 2010-05-26 16:49 Justin P. Mattock
2010-05-26 17:05 ` [ath9k-devel] " Luis R. Rodriguez
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Justin P. Mattock @ 2010-05-26 16:49 UTC (permalink / raw)
To: ath9k-devel; +Cc: mcgrog, linux-kernel, Justin P. Mattock
ath_print in xmit.c should say "Reseting hardware"
instead of Reaseting HAL!(since HAL is being fazed out).
dmesg shows:
[ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
[ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 3db1917..2a0558e 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
int r;
ath_print(common, ATH_DBG_FATAL,
- "Unable to stop TxDMA. Reset HAL!\n");
+ "Unable to stop TxDMA. Reseting hardware!\n");
spin_lock_bh(&sc->sc_resetlock);
r = ath9k_hw_reset(ah, sc->sc_ah->curchan, false);
--
1.6.5.GIT
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [ath9k-devel] [PATCH]wireless:ath9k Fix ath_print in xmit.c
2010-05-26 16:49 [PATCH]wireless:ath9k Fix ath_print in xmit.c Justin P. Mattock
@ 2010-05-26 17:05 ` Luis R. Rodriguez
2010-05-26 17:08 ` Justin P. Mattock
2010-05-26 17:16 ` Justin P. Mattock
2010-05-26 23:06 ` Peter Stuge
2010-05-27 20:59 ` Roland Dreier
2 siblings, 2 replies; 9+ messages in thread
From: Luis R. Rodriguez @ 2010-05-26 17:05 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: ath9k-devel, linux-kernel, mcgrog
On Wed, May 26, 2010 at 9:49 AM, Justin P. Mattock
<justinmattock@gmail.com> wrote:
> ath_print in xmit.c should say "Reseting hardware"
> instead of Reaseting HAL!(since HAL is being fazed out).
> dmesg shows:
> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
> ---
> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
> index 3db1917..2a0558e 100644
> --- a/drivers/net/wireless/ath/ath9k/xmit.c
> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
> int r;
>
> ath_print(common, ATH_DBG_FATAL,
> - "Unable to stop TxDMA. Reset HAL!\n");
> + "Unable to stop TxDMA. Reseting hardware!\n");
Thanks for the patch but you need to send this to John, cc linux-wireless.
Luis
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [ath9k-devel] [PATCH]wireless:ath9k Fix ath_print in xmit.c
2010-05-26 17:05 ` [ath9k-devel] " Luis R. Rodriguez
@ 2010-05-26 17:08 ` Justin P. Mattock
2010-05-26 17:16 ` Justin P. Mattock
1 sibling, 0 replies; 9+ messages in thread
From: Justin P. Mattock @ 2010-05-26 17:08 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: ath9k-devel, linux-kernel, mcgrog
On 05/26/2010 10:05 AM, Luis R. Rodriguez wrote:
> On Wed, May 26, 2010 at 9:49 AM, Justin P. Mattock
> <justinmattock@gmail.com> wrote:
>
>> ath_print in xmit.c should say "Reseting hardware"
>> instead of Reaseting HAL!(since HAL is being fazed out).
>> dmesg shows:
>> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
>> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>>
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> ---
>> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
>> index 3db1917..2a0558e 100644
>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
>> int r;
>>
>> ath_print(common, ATH_DBG_FATAL,
>> - "Unable to stop TxDMA. Reset HAL!\n");
>> + "Unable to stop TxDMA. Reseting hardware!\n");
>>
> Thanks for the patch but you need to send this to John, cc linux-wireless.
>
> Luis
>
>
I'll resend with the proper Cc's
Justin P. mattock
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [ath9k-devel] [PATCH]wireless:ath9k Fix ath_print in xmit.c
2010-05-26 17:05 ` [ath9k-devel] " Luis R. Rodriguez
2010-05-26 17:08 ` Justin P. Mattock
@ 2010-05-26 17:16 ` Justin P. Mattock
1 sibling, 0 replies; 9+ messages in thread
From: Justin P. Mattock @ 2010-05-26 17:16 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: ath9k-devel, linux-kernel, mcgrog
On 05/26/2010 10:05 AM, Luis R. Rodriguez wrote:
> On Wed, May 26, 2010 at 9:49 AM, Justin P. Mattock
> <justinmattock@gmail.com> wrote:
>
>> ath_print in xmit.c should say "Reseting hardware"
>> instead of Reaseting HAL!(since HAL is being fazed out).
>> dmesg shows:
>> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
>> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>>
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> ---
>> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
>> index 3db1917..2a0558e 100644
>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
>> int r;
>>
>> ath_print(common, ATH_DBG_FATAL,
>> - "Unable to stop TxDMA. Reset HAL!\n");
>> + "Unable to stop TxDMA. Reseting hardware!\n");
>>
> Thanks for the patch but you need to send this to John, cc linux-wireless.
>
> Luis
>
>
alright resent with the other patch I had kicking around..
(hopefully the right Cc's)
cheers,
Justin P. Mattock
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [ath9k-devel] [PATCH]wireless:ath9k Fix ath_print in xmit.c
2010-05-26 16:49 [PATCH]wireless:ath9k Fix ath_print in xmit.c Justin P. Mattock
2010-05-26 17:05 ` [ath9k-devel] " Luis R. Rodriguez
@ 2010-05-26 23:06 ` Peter Stuge
2010-05-26 23:28 ` Justin P. Mattock
2010-05-26 23:30 ` Justin P. Mattock
2010-05-27 20:59 ` Roland Dreier
2 siblings, 2 replies; 9+ messages in thread
From: Peter Stuge @ 2010-05-26 23:06 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: ath9k-devel, linux-kernel, mcgrog
Justin P. Mattock wrote:
> ath_print in xmit.c should say "Reseting hardware"
I think that should be "Resetting hardware" with two t:s.
//Peter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]wireless:ath9k Fix ath_print in xmit.c
2010-05-26 16:49 [PATCH]wireless:ath9k Fix ath_print in xmit.c Justin P. Mattock
2010-05-26 17:05 ` [ath9k-devel] " Luis R. Rodriguez
2010-05-26 23:06 ` Peter Stuge
@ 2010-05-27 20:59 ` Roland Dreier
2010-05-27 21:04 ` Justin P. Mattock
2 siblings, 1 reply; 9+ messages in thread
From: Roland Dreier @ 2010-05-27 20:59 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: ath9k-devel, mcgrog, linux-kernel
> - "Unable to stop TxDMA. Reset HAL!\n");
> + "Unable to stop TxDMA. Reseting hardware!\n");
I hate to mention it but the correct spelling is "resetting."
--
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-05-27 21:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 16:49 [PATCH]wireless:ath9k Fix ath_print in xmit.c Justin P. Mattock
2010-05-26 17:05 ` [ath9k-devel] " Luis R. Rodriguez
2010-05-26 17:08 ` Justin P. Mattock
2010-05-26 17:16 ` Justin P. Mattock
2010-05-26 23:06 ` Peter Stuge
2010-05-26 23:28 ` Justin P. Mattock
2010-05-26 23:30 ` Justin P. Mattock
2010-05-27 20:59 ` Roland Dreier
2010-05-27 21:04 ` Justin P. Mattock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).