From: Andi Kleen <ak@linux.intel.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Jin Dongming <jin.dongming@np.css.fujitsu.com>,
LKLM <linux-kernel@vger.kernel.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Subject: Re: [Patch-next] Remove notify_die in do_machine_check functioin
Date: Thu, 27 May 2010 08:54:45 +0200 [thread overview]
Message-ID: <4BFE1735.9080806@linux.intel.com> (raw)
In-Reply-To: <1274930481.3444.258.camel@yhuang-dev.sh.intel.com>
> I have heard about that on some machine, some hardware error output pin
> of chipset may be linked with some input pin of CPU which can cause MCE.
Yes that happens.
> That is, MCE is used to report some chipset errors too. I think that is
> why notify_die is called in do_machine_check. Simply removing notify_die
> is not good for these machines.
In general deciding what to do on a MCE is rather complicated
and probably too much for any die handler.
> Maybe we should fix the notifier user instead. Which notifier user
> consumes the DIE_NMI notification?
Yes. It would be good to find out which user it is. Perhaps gdb?
One approach would be to give it a different type (DIE_MCE)
But today we don't really need it. notify_die() is primarily for debuggers
of all kinds, and I never liked the idea to call a debugger on a machine
check.
So I would be ok with just removing the call.
-Andi
next prev parent reply other threads:[~2010-05-27 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 2:40 [Patch-next] Remove notify_die in do_machine_check functioin Jin Dongming
2010-05-27 3:21 ` Huang Ying
2010-05-27 6:06 ` Hidetoshi Seto
2010-05-27 6:57 ` Andi Kleen
2010-05-27 6:54 ` Andi Kleen [this message]
2010-05-27 11:04 ` Alan Cox
2010-05-27 13:15 ` Andi Kleen
2010-05-27 6:58 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFE1735.9080806@linux.intel.com \
--to=ak@linux.intel.com \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox