Re: [PATCH] asm-generic: Use raw_local_irq_save/restore instead local_irq_save/restore

Yong Zhang
2010-05-27T09:13:07Z

On Wed, May 26, 2010 at 01:11:51PM -0400, Steven Rostedt wrote:
> On Wed, 2010-05-26 at 10:08 -0700, Andrew Morton wrote:
>
> >
> > If a developer looks at atomic_add_return() and asks himself "why did
> > this use raw_local_irq_save()", the only way of answering that question
> > is to go groveling through the git logs, which is a right PITA if
> > you're trying to get some coding work done.
> >
> > Guys, any time you add code which is non-obvious at the raw C level, it
> > *needs* a comment!
>
> Totally agree! I've gotten pretty good at adding comments to changes
> like this that I do. I need to get better at telling others to comment
> their work ;-)

Cc'ed Frederic Weisbecker

Seems like this issue has been raised before:
http://marc.info/?l=linux-kernel&m=126292794806169&w=2

I'm afraid this patch will trigger lockdep warning if atomic_inc()
is used in some locks.