Re: [PATCH] asm-generic: Use raw_local_irq_save/restore instead local_irq_save/restore

Michal Simek
2010-05-27T07:21:56Z

Steven Rostedt wrote:
> On Wed, 2010-05-26 at 10:08 -0700, Andrew Morton wrote:
>
>> If a developer looks at atomic_add_return() and asks himself "why did
>> this use raw_local_irq_save()", the only way of answering that question
>> is to go groveling through the git logs, which is a right PITA if
>> you're trying to get some coding work done.
>>
>> Guys, any time you add code which is non-obvious at the raw C level, it
>> *needs* a comment!
>
> Totally agree! I've gotten pretty good at adding comments to changes
> like this that I do. I need to get better at telling others to comment
> their work ;-)

ok. Will add any sensible comment.

Michal

--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian