From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759271Ab0E0RIX (ORCPT <rfc822;w@1wt.eu>);
	Thu, 27 May 2010 13:08:23 -0400
Received: from mx01.sz.bfs.de ([194.94.69.103]:51689 "EHLO mx01.sz.bfs.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757208Ab0E0RIV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 27 May 2010 13:08:21 -0400
Message-ID: <4BFEA700.20603@bfs.de>
Date: Thu, 27 May 2010 19:08:16 +0200
From: walter harms <wharms@bfs.de>
Reply-To: wharms@bfs.de
User-Agent: Thunderbird 2.0.0.24 (X11/20100302)
MIME-Version: 1.0
To: Dan Carpenter <error27@gmail.com>, Julia Lawall <julia@diku.dk>,
       HighPoint Linux Team <linux@highpoint-tech.com>,
       "James E.J. Bottomley" <James.Bottomley@suse.de>,
       linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference
References: <Pine.LNX.4.64.1005271433330.5422@ask.diku.dk> <20100527165301.GU22515@bicker>
In-Reply-To: <20100527165301.GU22515@bicker>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



Dan Carpenter schrieb:
> On Thu, May 27, 2010 at 02:33:47PM +0200, Julia Lawall wrote:
>> If it is a problem to use 0 when host is NULL, then the code could be fixed
>> in another way.
>>
> 
> Yeah.  It seems like it would be better to give a clearly bogus number.
> I would have said -1 but "scsi-1" looks normal so maybe something like 
> 9999999?
> 

lets spend some bytes:

	
	if (host)
		dprintk("scsi%d: hptiop_probe failed\n",host->host_no);
	else
		dprintk("scsi: no host, hptiop_probe failed\n");



re,
 wh