Re: [RFC][PATCH] mmc: add an ioctl for erasing

[Adrian Hunter <adrian.hunter@nokia.com>]

Christoph Hellwig wrote:
> On Mon, May 31, 2010 at 11:45:37AM +0300, Adrian Hunter wrote:
>> Sorry for the slow reply, I have been away.
>>
>> Connecting erase to discard was rejected for performance reasons in 2008.
>> Refer:
>>
>> 	http://thread.gmane.org/gmane.linux.file-systems/25378/focus=25606
> 
> The discard implementation changed a lot since those days.  Discard
> requests now have their own request size limitation which is separate
> form that for normal requests, and we also store the alignment
> requirement for them separately.
> 


I tested extensively at that time with all changes necessary to allow
discards to produce MMC erases that work with maximum efficacy.  There was
no performance benefit and operations like file deletion were much slower.

If connecting discard to MMC erase does not always improve performance, then
many people will have to change their mount options to include nodiscard.
Alternatively, if the connection is an optional configuration, then the
ioctl won't work all the time.

The erase ioctl needs to be separate from discard, which means it can be
made to support secure erase also.