From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756897Ab0EaR0O (ORCPT ); Mon, 31 May 2010 13:26:14 -0400 Received: from mail.netservers.co.uk ([80.248.178.71]:44682 "EHLO mail.netservers.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755555Ab0EaR0L (ORCPT ); Mon, 31 May 2010 13:26:11 -0400 X-Greylist: delayed 3901 seconds by postgrey-1.27 at vger.kernel.org; Mon, 31 May 2010 13:26:10 EDT X-Envelope-From: ben@netservers.co.uk Message-ID: <4C03E1CD.4000809@netservers.co.uk> Date: Mon, 31 May 2010 17:20:29 +0100 From: Ben McKeegan User-Agent: Mozilla-Thunderbird 2.0.0.24 (X11/20100328) MIME-Version: 1.0 To: Paul Mackerras CC: netdev@vger.kernel.org, linux-ppp@vger.kernel.org, Alan Cox , "Alexander E. Patrakov" , Richard Hartmann , linux-kernel@vger.kernel.org Subject: Re: [Patch] fix packet loss and massive ping spikes with PPP multi-link References: <2d460de71003260850x7f90d04cy79ac853464108182@mail.gmail.com> <20100326160226.0159ac3b@lxorguk.ukuu.org.uk> <4BACE827.4070006@gmail.com> <20100326170428.6c1ad66c@lxorguk.ukuu.org.uk> <4BB31E00.8060204@netservers.co.uk> <20100529021624.GA2538@brick.ozlabs.ibm.com> In-Reply-To: <20100529021624.GA2538@brick.ozlabs.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Mackerras wrote: >> I needed to do something similar a while back and I took a very >> different approach, which I think is more flexible. Rather than >> implement a new round-robin scheduler I simply introduced a target >> minimum fragment size into the fragment size calculation, as a per >> bundle parameter that can be configured via a new ioctl. This >> modifies the algorithm so that it tries to limit the number of >> fragments such that each fragment is at least the minimum size. If >> the minimum size is greater than the packet size it will not be >> fragmented all but will instead just get sent down the next >> available channel. >> >> A pppd plugin generates the ioctl call allowing this to be tweaked >> per connection. It is more flexible in that you can still have the >> larger packets fragmented if you wish. > > I like this a lot better than the other proposed patch. It adds less > code because it uses the fact that ppp_mp_explode() already has a > round-robin capability using the ppp->nxchan field, plus it provides a > way to control it per bundle via pppd. > > If you fix up the indentation issues (2-space indent in some of the > added code -- if you're using emacs, set c-basic-offset to 8), I'll > ack it and hopefully DaveM will pick it up. Okay, I'll fix it up when I'm back at work Tuesday and submit (today is a UK public holiday) and also dig out and fix up the userspace code to go with it. Ben.