public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [GIT] kbuild changes for 2.6.35
       [not found] ` <alpine.LFD.2.00.1005300921000.4639@i5.linux-foundation.org>
@ 2010-05-31 12:02   ` Michal Marek
  2010-06-01 15:32     ` Linus Torvalds
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Marek @ 2010-05-31 12:02 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-kernel, linux-kbuild, a.beregalov, andi, dzickus, fejes,
	g.liakhovetski, gthelen, hschauhan, hui.zhu, jan3sobi3ski, jay,
	jgunthorpe, jkacur, joe, kirr, lizf, nir.tzachar, rabin, rientjes,
	roland, saalwaechter, shemminger, tabbott, u.kleine-koenig,
	vbendeb, vda.linux, wuzhangjin, xt28

[ It seems that vger does not like the long Cc: line, let's try with email
addresses only ]


On Sun, May 30, 2010 at 09:22:20AM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 27 May 2010, Michal Marek wrote:
> >
> > Denys Vlasenko (18):
> >       Rename .bss.stack to .bss..stack.
> 
> There's a ton of these, and none of them have any explanation 
> what-so-ever.
> 
> I refuse to take stuff like this. If I don't know why somethign happens, I 
> don't want to pull it.

Sorry, here is a more complete description of the changes.
Alternatively, would you pull a branch with the section rename stuff taken
out?

Summary of the changes:
- A new configuration interface (make nconfig)
- Improvements to the other *config interfaces
- Better modpost mismatch reporting
- Section rename to allow for -ffunction-sections -fdata-sections
- Untagged builds without LOCALVERSION_AUTO have a '+' appended to the
  version string
- Lots of minor fixes & improvements.


The following changes since commit abe94c756c08d50566c09a65b9c7fe72f83071c5:
  Linus Torvalds (1):
        Linux 2.6.33-rc6

are available in the git repository at:

  git://repo.or.cz/linux-kbuild.git for-35

Alexander Beregalov (1):
      genksyms: close ref_file after use

Andi Kleen (2):
      Improve kconfig symbol hashing
      kbuild: move -fno-dwarf2-cfi-asm to powerpc only

David Rientjes (1):
      kbuild: improve version string logic

Denys Vlasenko (18):
      Rename .bss.stack to .bss..stack.
      Rename .data.gate to .data..gate.
      Rename .data.init_irqstack to .data..init_irqstack.
      Rename .data..patch.XXX to .data..patch.XXX.
      Rename .data[.percpu][.XXX] to .data[..percpu][..XXX].
      Rename .data.read_mostly to .data..read_mostly.
      Rename .data.vmpages and .data.vm0.XXX to .data..vmpages and .data..vm0.XXX.
      Rename .rodata.compressed to .rodata..compressed.
      Rename .text.ivt to .text..ivt.
      Rename .text.lock to .text..lock.
      Rename .text.page_aligned to .text..page_aligned.
      Rename .text.startup to .text..startup.
      Rename .data.nosave to .data..nosave.
      Rename .data.init to .data..init.
      Rename .data.initvect to .data..initvect.
      Rename .data.lock_aligned to .data..lock_aligned.
      Rename special text sections in arch/frv from .text.XXX to .text..XXX.
      Rename .text.start to .text..start.

Don Zickus (1):
      scripts: change scripts to use system python instead of env

FEJES Jozsef (1):
      kbuild: deb-pkg md5sums

Greg Thelen (1):
      kbuild: Fix checking of scm-identifier variable

Guennadi Liakhovetski (1):
      tags: include headers before source files

Himanshu Chauhan (1):
      scripts/kallsyms: suppress build warning

Hui Zhu (3):
      markup_oops.pl: fix for faulting instruction in the first line of a range
      markup_oops.pl: add options to improve cross-sompilation environments
      markup_oops.pl: minor fixes

Jan III Sobieski (1):
      add random binaries to .gitignore

Jason Gunthorpe (1):
      kbuild: Include gen_initramfs_list.sh and the file list in the .d file

Jiafu He (1):
      kbuild: Fix linking error built-in.o no such file or directory

Joe Perches (1):
      Makefile: Document ability to make file.lst and file.S

John Kacur (2):
      tags: Fix spelling error in comment (is->if)
      tags: Add the ability to make tags for all archs using "all"

John Saalwaechter (1):
      scripts: use %_tmppath in "make rpm-pkg"

Kirill Smelkov (1):
      kbuild: fix a couple of typos in Documentation

Li Zefan (7):
      kconfig: recalc symbol value before showing search results
      kconfig: some small fixes
      kconfig: fix zconfdump()
      gconfig: remove dbg_print_ptype() and dbg_print_stype()
      gconfig: remove show_debug option
      menuconfig: add support to show hidden options which have prompts
      gconfig: add support to show hidden options that have prompts

Michal Marek (9):
      nconfig: mark local functions as such
      scripts/mkcompile_h: don't test for hardcoded paths
      MAINTAINERS: add a few more patterns to kbuild
      Merge branch 'modpost' of git://git.pengutronix.de/git/ukl/linux-2.6 into kbuild/for-next
      tags: Use $SRCARCH
      kbuild: Do not unnecessarily regenerate modules.builtin
      Revert "kbuild: specify absolute paths for cscope"
      kbuild: Generate modules.builtin in make modules_install
      kbuild: Revert part of e8d400a to resolve a conflict

Nir Tzachar (1):
      nconfig: minor fix

Philipp Kohlbecher (1):
      .gitignore: ignore *.lzo files

Rabin Vincent (1):
      scripts: add ARM support to decodecode

Roland McGrath (1):
      kconfig CROSS_COMPILE option

Stephen Hemminger (9):
      scripts: improve checkstack
      checkincludes: fix perlcritic warnings
      checkversion: perl cleanup
      namespace: perlcritic warnings
      profile2linkerlist: fix perl warnings
      export_report: fix perl warnings
      headers_check: fix perl warnings
      headers_install: use local file handles
      headerdep: perlcritic warning

Tim Abbott (5):
      Rename .data.cacheline_aligned to .data..cacheline_aligned.
      Rename .data.init_task to .data..init_task.
      powerpc: remove unused __page_aligned definition.
      Rename .data.page_aligned to .data..page_aligned.
      Rename .bss.page_aligned to .bss..page_aligned.

Uwe Kleine-König (7):
      modpost: members of *driver structs should not point to __init functions
      modpost: define ALL_XXX{IN,EX}IT_SECTIONS
      modpost: give most mismatch constants a better name
      modpost: pass around const struct sectioncheck * instead of enum mismatch
      modpost: remove now unused NO_MISMATCH constant
      modpost: make symbol white list a per mismatch type variable
      modpost: don't allow *driver to reference .init.*

Vadim Bendebury (вб) (1):
      menuconfig: wrap long help lines

Wu Zhangjin (1):
      scripts/Makefile.lib: Align the output of LZO

nir.tzachar@gmail.com (1):
      kconfig: new configuration interface (nconfig)

 .gitignore                                |    1 +
 Documentation/.gitignore                  |    7 +
 Documentation/kbuild/kbuild.txt           |    6 +-
 Documentation/kbuild/kconfig-language.txt |    2 +-
 Documentation/mutex-design.txt            |    4 +-
 MAINTAINERS                               |    5 +-
 Makefile                                  |   65 +-
 arch/frv/kernel/break.S                   |    4 +-
 arch/frv/kernel/entry.S                   |    2 +-
 arch/frv/kernel/head.S                    |    2 +-
 arch/frv/kernel/vmlinux.lds.S             |   10 +-
 arch/frv/mm/tlb-miss.S                    |    2 +-
 arch/h8300/boot/compressed/head.S         |    2 +-
 arch/h8300/boot/compressed/vmlinux.lds    |    2 +-
 arch/ia64/include/asm/asmmacro.h          |   12 +-
 arch/ia64/include/asm/cache.h             |    2 +-
 arch/ia64/include/asm/percpu.h            |    2 +-
 arch/ia64/kernel/Makefile.gate            |    2 +-
 arch/ia64/kernel/gate-data.S              |    2 +-
 arch/ia64/kernel/gate.S                   |    8 +-
 arch/ia64/kernel/gate.lds.S               |   10 +-
 arch/ia64/kernel/init_task.c              |    2 +-
 arch/ia64/kernel/ivt.S                    |    2 +-
 arch/ia64/kernel/minstate.h               |    4 +-
 arch/ia64/kernel/paravirtentry.S          |    2 +-
 arch/ia64/kernel/vmlinux.lds.S            |   28 +-
 arch/ia64/kvm/vmm_ivt.S                   |    2 +-
 arch/ia64/scripts/unwcheck.py             |    2 +-
 arch/ia64/xen/gate-data.S                 |    2 +-
 arch/ia64/xen/xensetup.S                  |    2 +-
 arch/m68knommu/kernel/vmlinux.lds.S       |    4 +-
 arch/m68knommu/platform/68360/head-ram.S  |    2 +-
 arch/m68knommu/platform/68360/head-rom.S  |    2 +-
 arch/mips/lasat/image/head.S              |    2 +-
 arch/mips/lasat/image/romscript.normal    |    2 +-
 arch/parisc/include/asm/cache.h           |    2 +-
 arch/parisc/include/asm/system.h          |    2 +-
 arch/parisc/kernel/head.S                 |    2 +-
 arch/parisc/kernel/init_task.c            |    6 +-
 arch/parisc/kernel/vmlinux.lds.S          |   12 +-
 arch/powerpc/Makefile                     |    5 +
 arch/powerpc/include/asm/cache.h          |    2 +-
 arch/powerpc/include/asm/page_64.h        |    8 -
 arch/powerpc/kernel/vmlinux.lds.S         |   10 +-
 arch/s390/include/asm/cache.h             |    2 +-
 arch/s390/kernel/swsusp_asm64.S           |    2 +-
 arch/sh/boot/compressed/vmlinux.scr       |    2 +-
 arch/sh/include/asm/cache.h               |    2 +-
 arch/sparc/boot/btfixupprep.c             |    2 +-
 arch/sparc/include/asm/cache.h            |    2 +-
 arch/um/kernel/dyn.lds.S                  |    2 +-
 arch/um/kernel/init_task.c                |    2 +-
 arch/um/kernel/uml.lds.S                  |    2 +-
 arch/x86/.gitignore                       |    3 +
 arch/x86/boot/compressed/mkpiggy.c        |    2 +-
 arch/x86/boot/compressed/vmlinux.lds.S    |    4 +-
 arch/x86/include/asm/cache.h              |    2 +-
 arch/x86/kernel/acpi/wakeup_32.S          |    2 +-
 arch/x86/kernel/init_task.c               |    2 +-
 arch/x86/kernel/setup_percpu.c            |    2 +-
 arch/x86/kernel/vmlinux.lds.S             |    4 +-
 include/asm-generic/percpu.h              |   10 +-
 include/asm-generic/vmlinux.lds.h         |   38 +-
 include/linux/cache.h                     |    2 +-
 include/linux/init.h                      |    2 +-
 include/linux/init_task.h                 |    2 +-
 include/linux/linkage.h                   |    8 +-
 include/linux/percpu-defs.h               |    4 +-
 include/linux/spinlock.h                  |    2 +-
 init/Kconfig                              |    8 +
 kernel/module.c                           |    2 +-
 scripts/Makefile.build                    |    2 +-
 scripts/Makefile.lib                      |    2 +-
 scripts/checkincludes.pl                  |   24 +-
 scripts/checkstack.pl                     |   16 +-
 scripts/checkversion.pl                   |   23 +-
 scripts/decodecode                        |   48 +-
 scripts/export_report.pl                  |   37 +-
 scripts/gen_initramfs_list.sh             |    3 +-
 scripts/genksyms/genksyms.c               |    4 +-
 scripts/headerdep.pl                      |    3 +-
 scripts/headers_check.pl                  |   11 +-
 scripts/headers_install.pl                |   19 +-
 scripts/kallsyms.c                        |    6 +-
 scripts/kconfig/Makefile                  |   16 +-
 scripts/kconfig/expr.c                    |   27 +-
 scripts/kconfig/expr.h                    |    5 +-
 scripts/kconfig/gconf.c                   |  113 +--
 scripts/kconfig/gconf.glade               |   26 +-
 scripts/kconfig/lkc.h                     |    7 +-
 scripts/kconfig/lkc_proto.h               |    6 +-
 scripts/kconfig/lxdialog/inputbox.c       |    4 +-
 scripts/kconfig/lxdialog/menubox.c        |   22 +-
 scripts/kconfig/mconf.c                   |   36 +-
 scripts/kconfig/menu.c                    |   28 +-
 scripts/kconfig/nconf.c                   | 1568 +++++++++++++++++++++++++++++
 scripts/kconfig/nconf.gui.c               |  617 ++++++++++++
 scripts/kconfig/nconf.h                   |   95 ++
 scripts/kconfig/symbol.c                  |   30 +-
 scripts/kconfig/util.c                    |    2 +
 scripts/kconfig/zconf.tab.c_shipped       |   25 +-
 scripts/kconfig/zconf.y                   |   25 +-
 scripts/markup_oops.pl                    |   54 +-
 scripts/mkcompile_h                       |    5 +-
 scripts/mod/modpost.c                     |  152 ++--
 scripts/namespace.pl                      |   65 +-
 scripts/package/builddeb                  |    2 +
 scripts/package/mkspec                    |    2 +-
 scripts/profile2linkerlist.pl             |    8 +-
 scripts/rt-tester/rt-tester.py            |    2 +-
 scripts/show_delta                        |    2 +-
 scripts/tags.sh                           |   45 +-
 112 files changed, 3024 insertions(+), 539 deletions(-)
 create mode 100644 Documentation/.gitignore
 create mode 100644 arch/x86/.gitignore
 create mode 100644 scripts/kconfig/nconf.c
 create mode 100644 scripts/kconfig/nconf.gui.c
 create mode 100644 scripts/kconfig/nconf.h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT] kbuild changes for 2.6.35
  2010-05-31 12:02   ` [GIT] kbuild changes for 2.6.35 Michal Marek
@ 2010-06-01 15:32     ` Linus Torvalds
  2010-06-01 19:55       ` Michal Marek
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2010-06-01 15:32 UTC (permalink / raw)
  To: Michal Marek
  Cc: linux-kernel, linux-kbuild, a.beregalov, andi, dzickus, fejes,
	g.liakhovetski, gthelen, hschauhan, hui.zhu, jan3sobi3ski, jay,
	jgunthorpe, jkacur, joe, kirr, lizf, nir.tzachar, rabin, rientjes,
	roland, saalwaechter, shemminger, tabbott, u.kleine-koenig,
	vbendeb, vda.linux, wuzhangjin, xt28



On Mon, 31 May 2010, Michal Marek wrote:
> > 
> > I refuse to take stuff like this. If I don't know why somethign happens, I 
> > don't want to pull it.
> 
> Sorry, here is a more complete description of the changes.
> Alternatively, would you pull a branch with the section rename stuff taken
> out?

No, the commits themselves are likely fine, although for the future it 
really would be good to make things like that more descriptive. I just 
want people to try to argue for _why_ I should do a pull, and _what_ I'm 
getting in their "please pull" thing.

It's not always necessary, and some people do it better than others. For 
an example of a really good pull request, look at the ones David Miller 
sends me for networking - they explain what's going on in the pull, so 
it's always easy to pull them because just the request makes me feel like 
David is really on top of things, and lets me have some 30'000 ft overview 
of what's going on.

At the same time, in many cases I obviously pull _without_ any kind of 
real explanation - and that tends to be especially true with maintainers 
that I've worked with for a long time, or areas that are so specialized 
that they are almost self-explanatory (let's be honest: when a filesystem 
maintainer asks me to pull their special filesystem, I'm perfectly happy 
with the overview of "30 changesets to XFS", and there's no need for much 
explanation, although a rough overview of what's been going on is always 
good to see).

So the reason I ask for explanations for kbuild is that not only have we 
had different maintainers, it's an area that affects a lot of different 
things and has historically had issues with odd architectures or old 
binutils tools etc.

So for something like that, I really do want to know what is going on, and 
then when I get a pull request with little to no explanation, and look at 
a trial pull with "gitk ORIG_HEAD.." and see no additional explanation 
there either, I just go "no, I can't pull this, I don't really know what 
it does or why it does so".

> Summary of the changes:
> - A new configuration interface (make nconfig)
> - Improvements to the other *config interfaces
> - Better modpost mismatch reporting
> - Section rename to allow for -ffunction-sections -fdata-sections
> - Untagged builds without LOCALVERSION_AUTO have a '+' appended to the
>   version string
> - Lots of minor fixes & improvements.

So I really want to know _why_ that section rename is specifically like it 
is. Why is ".data..stack" better than ".data.stack"?

			Linus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT] kbuild changes for 2.6.35
  2010-06-01 15:32     ` Linus Torvalds
@ 2010-06-01 19:55       ` Michal Marek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2010-06-01 19:55 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-kernel, linux-kbuild, a.beregalov, andi, dzickus, fejes,
	g.liakhovetski, gthelen, hschauhan, hui.zhu, jan3sobi3ski, jay,
	jgunthorpe, jkacur, joe, kirr, lizf, nir.tzachar, rabin, rientjes,
	roland, saalwaechter, shemminger, tabbott, u.kleine-koenig,
	vbendeb, vda.linux, wuzhangjin, xt28

On 1.6.2010 17:32, Linus Torvalds wrote:
> No, the commits themselves are likely fine, although for the future it 
> really would be good to make things like that more descriptive. I just 
> want people to try to argue for _why_ I should do a pull, and _what_ I'm 
> getting in their "please pull" thing.
> 
> It's not always necessary, and some people do it better than others. For 
> an example of a really good pull request, look at the ones David Miller 
> sends me for networking - they explain what's going on in the pull, so 
> it's always easy to pull them because just the request makes me feel like 
> David is really on top of things, and lets me have some 30'000 ft overview 
> of what's going on.

OK, I'll try to do better job next time. I'm also going to use different
branches for kbuild / kconfig / trivial stuff like .gitignore / etc from
now on, so that you don't get a all-or-nothing pull request in the next
merge window (something that Sam suggested).


> At the same time, in many cases I obviously pull _without_ any kind of 
> real explanation - and that tends to be especially true with maintainers 
> that I've worked with for a long time, or areas that are so specialized 
> that they are almost self-explanatory (let's be honest: when a filesystem 
> maintainer asks me to pull their special filesystem, I'm perfectly happy 
> with the overview of "30 changesets to XFS", and there's no need for much 
> explanation, although a rough overview of what's been going on is always 
> good to see).
> 
> So the reason I ask for explanations for kbuild is that not only have we 
> had different maintainers, it's an area that affects a lot of different 
> things and has historically had issues with odd architectures or old 
> binutils tools etc.

I see. Thanks a lot for pulling the changes now.

Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-06-01 19:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20100527144459.GA14513@sepie.suse.cz>
     [not found] ` <alpine.LFD.2.00.1005300921000.4639@i5.linux-foundation.org>
2010-05-31 12:02   ` [GIT] kbuild changes for 2.6.35 Michal Marek
2010-06-01 15:32     ` Linus Torvalds
2010-06-01 19:55       ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox