From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: cpqphp: NULL ptr deref in cpqhpc_probe
Date: Thu, 03 Jun 2010 11:26:32 +0200 [thread overview]
Message-ID: <4C077548.90203@gmail.com> (raw)
In-Reply-To: <4C0774C6.4090000@suse.cz>
On 06/03/2010 11:24 AM, Jiri Slaby wrote:
> we have a system where there is a pci hotplug class device to be handled
> by cpqphp, but it is not a bridge. But in cpqhpc_probe there is:
> struct pci_bus *bus;
> ...
> bus = pdev->subordinate;
> ...
> bus->max_bus_speed = PCI_SPEED_66MHz_PCIX;
>
> But as it is not a bridge, subordinate is NULL and the kernel crashes.
>
> Any idea what would be a correct fix here?
>
> The bugzilla entry is at:
> https://bugzilla.novell.com/show_bug.cgi?id=609338
I forgot to attach the device information:
00:0b.0 PCI Hot-plug controller: Compaq Computer Corporation PCI Hotplug
Controller (rev 11)
Subsystem: Compaq Computer Corporation Device a2f8
Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr+
Stepping- SERR+ FastB2B- DisINTx-
Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=slow >TAbort- <TAbort-
<MAbort- >SERR- <PERR- INTx-
Interrupt: pin A routed to IRQ 15
Region 0: Memory at f7ad0000 (32-bit, non-prefetchable) [size=256]
next prev parent reply other threads:[~2010-06-03 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 9:24 cpqphp: NULL ptr deref in cpqhpc_probe Jiri Slaby
2010-06-03 9:26 ` Jiri Slaby [this message]
2010-06-08 21:37 ` Jesse Barnes
2010-06-08 22:05 ` Greg KH
2010-06-10 22:34 ` Alex Chiang
2010-06-10 23:19 ` Greg KH
2010-06-10 23:28 ` Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C077548.90203@gmail.com \
--to=jirislaby@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox