From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5]alsa:patch_realtek.c Add SSID table for MacBookAir2,1
Date: Tue, 08 Jun 2010 09:11:13 -0700 [thread overview]
Message-ID: <4C0E6BA1.3080200@gmail.com> (raw)
In-Reply-To: <s5h39wxk1p6.wl%tiwai@suse.de>
On 06/08/2010 08:01 AM, Takashi Iwai wrote:
> At Sun, 6 Jun 2010 16:09:49 -0700,
> Justin P. Mattock wrote:
>>
>> This adds the SSID number to snd_pci_quirk for the
>> MacBookAir2,1 taken from codec#0 at:
>> http://launchpadlibrarian.net/49455483/Card0.Codecs.codec.0.txt
>> keep in mind I do not have one of these machines on hand
>> so please if you do have this machine please test for me..
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>
> I applied this one (after rearranging the quirk list order).
>
> Also the patch 3 and 5, both one-liner additions of a quirk, are
> applied, too, since they got tested somehow in bug reports.
>
> Could you rebase your changes for the proper MBA 1,1 and imac 7,1
> against the latest sound tree so that anyone can test them? If they
> work better, then we can apply later your changes in addition.
>
>
> Thanks!
>
> Takashi
>
o.k. cool..
I'll rebase those two patches and send them out
(hopefully people test)..
>> ---
>> sound/pci/hda/patch_realtek.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 17d4548..9b82d28 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -9487,6 +9487,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
>> SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5),
>> SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5),
>> SND_PCI_QUIRK(0x106b, 0x4100, "Macmini 3,1", ALC885_MACMINI3),
>> + SND_PCI_QUIRK(0x106b, 0x3500, "MacBookAir 2,1", ALC885_MBA21),
>> {} /* terminator */
>> };
>>
>> --
>> 1.6.5.2.180.gc5b3e
>>
>
cheers,
Justin P. Mattock
next prev parent reply other threads:[~2010-06-08 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 23:09 [PATCH 1/5]alsa:patch_realtek.c Add SSID table for MacBookAir2,1 Justin P. Mattock
2010-06-06 23:09 ` [PATCH 2/5]alsa:patch_realtek.c Add support for the MacBookAir1,1 Justin P. Mattock
2010-06-06 23:09 ` [PATCH 3/5]alsa:patch_realtek.c Add SSID table for MacBookAir1,1 Justin P. Mattock
2010-06-06 23:09 ` [PATCH 4/5]alsa:patch_realtek.c Add support for the iMac7,1 Justin P. Mattock
2010-06-06 23:09 ` [PATCH 5/5]alsa:patch_realtek.c Add SSID table for iMac7,1 Justin P. Mattock
2010-06-08 15:01 ` [PATCH 1/5]alsa:patch_realtek.c Add SSID table for MacBookAir2,1 Takashi Iwai
2010-06-08 16:11 ` Justin P. Mattock [this message]
2010-06-08 17:50 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0E6BA1.3080200@gmail.com \
--to=justinmattock@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox