From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
Linux-kernel <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: xfs, 2.6.27=>.32 sync write 10 times slowdown [was: xfs, aacraid 2.6.27 => 2.6.32 results in 6 times slowdown]
Date: Thu, 10 Jun 2010 09:58:25 -0500 [thread overview]
Message-ID: <4C10FD91.4060209@sandeen.net> (raw)
In-Reply-To: <20100610004701.GN7869@dastard>
Dave Chinner wrote:
> On Wed, Jun 09, 2010 at 11:11:53PM +0400, Michael Tokarev wrote:
>> The same is with -o osyncisosync (in .34). Actually,
>> osyncis[od]sync mount options does not change anything, not
>> in .32 nor in .34.
>
> I think only osyncisosync exists, and it doesn't do anything
> anymore.
Just to be pedantic, osyncisdsync "exists," but is deprecated and does
nothing to change defaults:
} else if (!strcmp(this_char, "osyncisdsync")) {
/* no-op, this is now the default */
cmn_err(CE_WARN,
"XFS: osyncisdsync is now the default, option is deprecated.");
}
huh, didn't realize that osyncisosync does nothing but set a flag that
is never tested other than to show mount options:
File Function Line
0 xfs_mount.h <global> 285 #define XFS_MOUNT_OSYNCISOSYNC (1ULL << 13)
1 linux-2.6/xfs_super.c xfs_parseargs 292 mp->m_flags |= XFS_MOUNT_OSYNCISOSYNC;
2 linux-2.6/xfs_super.c xfs_showargs 542 { XFS_MOUNT_OSYNCISOSYNC, "," MNTOPT_OSYNCISOSYNC },
Time to deprecate/remove that one too I guess?
-Eric
> Cheers,
>
> Dave.
prev parent reply other threads:[~2010-06-10 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 9:55 xfs, aacraid 2.6.27 => 2.6.32 results in 6 times slowdown Michael Tokarev
2010-06-08 12:29 ` Dave Chinner
2010-06-08 20:34 ` xfs, 2.6.27=>.32 sync write 10 times slowdown [was: xfs, aacraid 2.6.27 => 2.6.32 results in 6 times slowdown] Michael Tokarev
2010-06-08 23:18 ` Dave Chinner
2010-06-09 6:43 ` Michael Tokarev
2010-06-09 7:47 ` Dave Chinner
2010-06-09 19:11 ` Michael Tokarev
2010-06-10 0:47 ` Dave Chinner
2010-06-10 5:59 ` Michael Tokarev
2010-06-10 14:58 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C10FD91.4060209@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox