From: Jens Axboe <jaxboe@fusionio.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [GIT PULL] block/io bits for 2.6.35-rc
Date: Thu, 10 Jun 2010 19:00:41 +0200 [thread overview]
Message-ID: <4C111A39.7000900@fusionio.com> (raw)
In-Reply-To: <AANLkTikKwoZKYsj2Nd98rIa8i947a-AlpEd47lkuHyro@mail.gmail.com>
On 2010-06-10 18:55, Linus Torvalds wrote:
> On Thu, Jun 10, 2010 at 9:25 AM, Jens Axboe <jaxboe@fusionio.com> wrote:
>>
>> It's fixing a regression where umount takes a LONG time if you have
>> a lot of dirty inodes, since it basically degenerates to a data
>> integrity writeback instead of a simple WB_SYNC_NONE. If it wasn't
>> fixing a nasty regression (the distros are all wanting a real fix
>> for this, it's a user problem), I would not be submitting this code
>> at this point in time.
>
> I'm not sure if you noticed, we had a separate thread with Dave
> Chinner that resulted in three hopefully fairly minimal patches going
> in instead.
>
> See commits
>
> git log -3 d87815cb2090
>
> and I thought that last one (first one applied: "pay attention to
> wbc->nr_to_write") was the one that had fixed the worst XFS issues.
>
> But maybe it was an unrelated thing.
That's a different bug.
--
Jens Axboe
prev parent reply other threads:[~2010-06-10 17:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 13:44 [GIT PULL] block/io bits for 2.6.35-rc Jens Axboe
2010-06-10 15:55 ` Linus Torvalds
2010-06-10 16:25 ` Jens Axboe
2010-06-10 16:40 ` Christoph Hellwig
2010-06-10 16:59 ` Jens Axboe
2010-06-10 17:03 ` Linus Torvalds
2010-06-10 16:44 ` Brian Bloniarz
2010-06-27 23:10 ` Mark Lord
2010-06-28 7:03 ` Jens Axboe
2010-06-28 9:41 ` Christoph Hellwig
2010-06-28 13:51 ` Mark Lord
2010-06-28 14:05 ` Brian Bloniarz
2010-06-28 14:33 ` Mark Lord
2010-06-28 17:32 ` Jens Axboe
2010-06-28 20:55 ` Mark Lord
2010-06-10 16:55 ` Linus Torvalds
2010-06-10 17:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C111A39.7000900@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox