From: Frank Rowand <frank.rowand@am.sony.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Bruno Premont <bonbons@linux-vserver.org>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: [patch] genirq: update comments related to buslock support
Date: Thu, 10 Jun 2010 13:54:10 -0700 [thread overview]
Message-ID: <4C1150F2.7020807@am.sony.com> (raw)
Update comments to match code change in 70aedd24
Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
---
kernel/irq/manage.c | 7 5 + 2 - 0 !
1 file changed, 5 insertions(+), 2 deletions(-)
Index: b/kernel/irq/manage.c
===================================================================
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -236,7 +236,8 @@ void __disable_irq(struct irq_desc *desc
* Unlike disable_irq(), this function does not ensure existing
* instances of the IRQ handler have completed before returning.
*
- * This function may be called from IRQ context.
+ * This function may be called from IRQ context only when
+ * desc->chip->bus_lock and desc->chip->bus_sync_unlock are NULL !
*/
void disable_irq_nosync(unsigned int irq)
{
@@ -264,7 +265,9 @@ EXPORT_SYMBOL(disable_irq_nosync);
* to complete before returning. If you use this function while
* holding a resource the IRQ handler may need you will deadlock.
*
- * This function may be called - with care - from IRQ context.
+ * This function may be called - with care - from IRQ context only when
+ * desc->chip->bus_lock and desc->chip->bus_sync_unlock are NULL !
+ * See synchronize_irq() comments for explanation of "with care".
*/
void disable_irq(unsigned int irq)
{
reply other threads:[~2010-06-10 20:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1150F2.7020807@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=bonbons@linux-vserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox