public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org
Subject: [PATCH 3/4] x86: ioremap: remove physical address warning message
Date: Fri, 11 Jun 2010 18:20:54 +0900	[thread overview]
Message-ID: <4C11FFF6.8040406@jp.fujitsu.com> (raw)
In-Reply-To: <4C11FF10.4060203@jp.fujitsu.com>

Current ioremap() code for x86 displays warning message if too high
address to handle is passed. But this can happen as usual cases. For
example, if 64-bit BAR is assigned to a PCI device and its device
driver calls pci_iomap(). So this patch changes the warning messages
as follows.

- Change printk message from KERN_WARNING to KERN_DEBUG
- Remove WARN_ON_ONCE()

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

---
 arch/x86/mm/ioremap.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6.34/arch/x86/mm/ioremap.c
===================================================================
--- linux-2.6.34.orig/arch/x86/mm/ioremap.c	2010-06-10 07:28:31.966187993 +0900
+++ linux-2.6.34/arch/x86/mm/ioremap.c	2010-06-10 07:28:33.146375380 +0900
@@ -78,9 +78,8 @@
 		return NULL;
 
 	if (!phys_addr_valid(phys_addr)) {
-		printk(KERN_WARNING "ioremap: invalid physical address %llx\n",
+		printk(KERN_DEBUG "ioremap: can't map physical address %llx\n",
 		       (unsigned long long)phys_addr);
-		WARN_ON_ONCE(1);
 		return NULL;
 	}
 



  parent reply	other threads:[~2010-06-11  9:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-11  9:17 [RFC][PATCH 0/4] x86: ioremap() problem in X86_32 PAE Kenji Kaneshige
2010-06-11  9:18 ` [PATCH 1/4] x86: ioremap: fix wrong address masking Kenji Kaneshige
2010-06-11  9:20 ` [PATCH 2/4] x86: ioremap: fix physical address check Kenji Kaneshige
2010-06-11 17:43   ` H. Peter Anvin
2010-06-14  0:18     ` KAMEZAWA Hiroyuki
2010-06-14  8:59       ` KAMEZAWA Hiroyuki
2010-06-14  9:13         ` Kenji Kaneshige
2010-06-14 11:06           ` Kenji Kaneshige
2010-06-14 18:36             ` H. Peter Anvin
2010-06-15  2:21               ` Kenji Kaneshige
2010-06-14 20:16             ` Rolf Eike Beer
2010-06-15  2:33               ` Kenji Kaneshige
2010-06-14  1:54     ` Kenji Kaneshige
2010-06-14  6:38       ` Maciej W. Rozycki
2010-06-14  8:23         ` Kenji Kaneshige
2010-06-14  9:02           ` Kenji Kaneshige
2010-06-14 15:40             ` H. Peter Anvin
2010-06-14 15:11         ` H. Peter Anvin
2010-06-14  8:27       ` Kenji Kaneshige
2010-06-14 15:12         ` H. Peter Anvin
2010-06-11  9:20 ` Kenji Kaneshige [this message]
2010-06-11 17:44   ` [PATCH 3/4] x86: ioremap: remove physical address warning message H. Peter Anvin
2010-06-14  2:06     ` Kenji Kaneshige
2010-06-11  9:21 ` [PATCH 4/4] x86: ioremap: fix normal ram range check Kenji Kaneshige
2010-06-11 17:41 ` [RFC][PATCH 0/4] x86: ioremap() problem in X86_32 PAE H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C11FFF6.8040406@jp.fujitsu.com \
    --to=kaneshige.kenji@jp.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox