Re: [PATCH 1/9] PM / Hibernate: swap, switch to hibernate_io_handle

Jiri Slaby
2010-06-21T15:23:29Z

On 06/10/2010 03:55 PM, Pavel Machek wrote:
> It would be good if you carried ack-s from previous rounds, so that I
> don't have to review good patches again...

Hi, previously ACKed patches were merged already. These were much
rewritten and their original versions were rather NACKed. Otherwise I
transfer ACKs indeed.

>> +/**
>> + * hib_io_handle_alloc - allocate io handle with priv_size for private data
>> + *
>> + * @priv_size: the sie to allocate behind hibernate_io_handle for private use
>> + */
>> +static inline struct hibernate_io_handle *hib_io_handle_alloc(size_t priv_size)
>> +{
>> + struct hibernate_io_handle *ret;
>> + ret = kzalloc(sizeof(*ret) + priv_size, GFP_KERNEL);
>> + if (ret)
>> + ret->priv = ret + 1;
>
> Uhuh, why this? Aha, grabbing the pointer to priv_size-sized area at
> the end of regular struct?

Yes, exactly, any more transparent way to do it?

--
js