From: "H. Peter Anvin" <hpa@zytor.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
jbarnes@virtuousgeek.org
Subject: Re: [RFC][PATCH 0/4] x86: ioremap() problem in X86_32 PAE
Date: Fri, 11 Jun 2010 10:41:05 -0700 [thread overview]
Message-ID: <4C127531.90902@zytor.com> (raw)
In-Reply-To: <4C11FF10.4060203@jp.fujitsu.com>
On 06/11/2010 02:17 AM, Kenji Kaneshige wrote:
>
> By the way, I'm wondering some change might be needed also in PCI side.
> For example, current PCI subsystem disables 64-bit BAR with address
> higher than 32-bit assigned if sizeof(resource_size_t) is less than 8.
> But it doesn't care the case sizeof(resource_size_t) is equal to 8 on
> the system that cannot handle whole 64-bit physical address, like
> X86_32 PAE. In relation to this, my system is doing the following
> interesting behavior.
>
> - On x86_32 without PAE, ioatdma works because 64-bit BAR is once
> cleared and then lower address is assigned again.
>
> - On x86_32 with PAE, ioatdma doesn' work even with my patch set.
> Without my patch, kernel hangup or panic happens. With my patch,
> ioatdma driver fails to initialize the device because ioremap()
> returns NULL.
>
> Anyway, I think ioremap() problem needs to be fixed first.
>
We had a patch in for a while to cap the physical address space to the
number of bits supported by the CPU. It got removed because it caused a
regression, which turned out to be because it exposed another bug (which
has since been fixed) -- I have been meaning to put it back in.
-hpa
prev parent reply other threads:[~2010-06-11 17:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 9:17 [RFC][PATCH 0/4] x86: ioremap() problem in X86_32 PAE Kenji Kaneshige
2010-06-11 9:18 ` [PATCH 1/4] x86: ioremap: fix wrong address masking Kenji Kaneshige
2010-06-11 9:20 ` [PATCH 2/4] x86: ioremap: fix physical address check Kenji Kaneshige
2010-06-11 17:43 ` H. Peter Anvin
2010-06-14 0:18 ` KAMEZAWA Hiroyuki
2010-06-14 8:59 ` KAMEZAWA Hiroyuki
2010-06-14 9:13 ` Kenji Kaneshige
2010-06-14 11:06 ` Kenji Kaneshige
2010-06-14 18:36 ` H. Peter Anvin
2010-06-15 2:21 ` Kenji Kaneshige
2010-06-14 20:16 ` Rolf Eike Beer
2010-06-15 2:33 ` Kenji Kaneshige
2010-06-14 1:54 ` Kenji Kaneshige
2010-06-14 6:38 ` Maciej W. Rozycki
2010-06-14 8:23 ` Kenji Kaneshige
2010-06-14 9:02 ` Kenji Kaneshige
2010-06-14 15:40 ` H. Peter Anvin
2010-06-14 15:11 ` H. Peter Anvin
2010-06-14 8:27 ` Kenji Kaneshige
2010-06-14 15:12 ` H. Peter Anvin
2010-06-11 9:20 ` [PATCH 3/4] x86: ioremap: remove physical address warning message Kenji Kaneshige
2010-06-11 17:44 ` H. Peter Anvin
2010-06-14 2:06 ` Kenji Kaneshige
2010-06-11 9:21 ` [PATCH 4/4] x86: ioremap: fix normal ram range check Kenji Kaneshige
2010-06-11 17:41 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C127531.90902@zytor.com \
--to=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox