From: "H. Peter Anvin" <hpa@zytor.com>
To: Hans Rosenfeld <hans.rosenfeld@amd.com>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] AMD errata checking framework
Date: Tue, 15 Jun 2010 11:16:54 -0700 [thread overview]
Message-ID: <4C17C396.2040002@zytor.com> (raw)
In-Reply-To: <20100614123342.GB746@escobedo.osrc.amd.com>
On 06/14/2010 05:33 AM, Hans Rosenfeld wrote:
>
>> Also, the use of divide and modulo when shifts and masks work are
>> generally frowned upon in Linux as a matter of style.
>
> While I agree in principle, I think that in this special case the
> divide and modulo by 64 make it easier to understand what the code
> does on the first look. But if you insist I will send another patch
> set that replaces divide and modulo with shifts and masks.
>
I do insist.
-hpa
next prev parent reply other threads:[~2010-06-15 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1276262713-26864-1-git-send-email-hans.rosenfeld@amd.com>
2010-06-11 20:14 ` [PATCH 1/2] AMD errata checking framework H. Peter Anvin
2010-06-14 12:33 ` Hans Rosenfeld
2010-06-15 18:16 ` H. Peter Anvin [this message]
2010-06-11 20:15 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C17C396.2040002@zytor.com \
--to=hpa@zytor.com \
--cc=hans.rosenfeld@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox