From: "H. Peter Anvin" <hpa@zytor.com>
To: Andres Salomon <dilinger@queued.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, x86@kernel.org, Mitch Bradley <wmb@laptop.org>
Subject: Re: [PATCH] x86: OLPC: add support for calling into OpenFirmware (v3)
Date: Wed, 16 Jun 2010 13:19:27 -0700 [thread overview]
Message-ID: <4C1931CF.6040200@zytor.com> (raw)
In-Reply-To: <20100616151335.039db487@dev.queued.net>
On 06/16/2010 12:13 PM, Andres Salomon wrote:
> @@ -658,6 +664,10 @@ ENTRY(stack_start)
> .long init_thread_union+THREAD_SIZE
> .long __BOOT_DS
>
> +.globl olpc_ofw_pgd
> +olpc_ofw_pgd:
> + .long olpc_ofw_pgd
> +
> ready: .byte 0
>
This variable doesn't need to be initialized, and so belongs .bss. You
don't need to declare it in an assembly file at all; it probably makes
more sense to just declare it a normal variable (possibly __init) inside
olpc_ofw.c.
Otherwise it's starting to look good.
-hpa
prev parent reply other threads:[~2010-06-16 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 19:13 [PATCH] x86: OLPC: add support for calling into OpenFirmware (v3) Andres Salomon
2010-06-16 20:19 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1931CF.6040200@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=wmb@laptop.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox