From: Tejun Heo <tj@kernel.org>
To: Cliff Wickman <cpw@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: per_cpu_ptr_to_phys() failure on UV x86_64
Date: Thu, 17 Jun 2010 19:08:09 +0200 [thread overview]
Message-ID: <4C1A5679.8010907@kernel.org> (raw)
In-Reply-To: <E1OPHpK-0007cw-S5@eag09.americas.sgi.com>
Hello,
On 06/17/2010 06:20 PM, Cliff Wickman wrote:
> phys_addr_t per_cpu_ptr_to_phys(void *addr)
> {
> + if ((unsigned long)addr < VMALLOC_START ||
> + (unsigned long)addr >= VMALLOC_END)
> + return __pa(addr);
> if (pcpu_addr_in_first_chunk(addr)) {
> - if ((unsigned long)addr < VMALLOC_START ||
> - (unsigned long)addr >= VMALLOC_END)
> - return __pa(addr);
> - else
> - return page_to_phys(vmalloc_to_page(addr));
> + return page_to_phys(vmalloc_to_page(addr));
> } else
> return page_to_phys(pcpu_addr_to_page(addr));
> }
(scratching head...) So, that means it's given an address for which
!pcpu_addr_in_first_chunk() but outside of vmalloc area. Strange.
I'll find out what's going on.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-06-17 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 16:20 per_cpu_ptr_to_phys() failure on UV x86_64 Cliff Wickman
2010-06-17 17:08 ` Tejun Heo [this message]
2010-06-17 17:35 ` Tejun Heo
2010-06-17 18:24 ` Cliff Wickman
2010-06-18 9:56 ` [PATCH] percpu: fix first chunk match in per_cpu_ptr_to_phys() Tejun Heo
2010-06-18 12:30 ` Cliff Wickman
2010-06-18 13:07 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1A5679.8010907@kernel.org \
--to=tj@kernel.org \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox