From: David Daney <ddaney@caviumnetworks.com>
To: Jesper Nilsson <jesper@jni.nu>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: MIPS: return after handling coprocessor 2 exception
Date: Thu, 17 Jun 2010 10:13:18 -0700 [thread overview]
Message-ID: <4C1A57AE.9080706@caviumnetworks.com> (raw)
In-Reply-To: <20100617132554.GB24162@jni.nu>
On 06/17/2010 06:25 AM, Jesper Nilsson wrote:
> Breaking here dropped us to the default code which always sends
> a SIGILL to the current process, no matter what the CU2 notifier says.
>
> Signed-off-by: Jesper Nilsson<jesper@jni.nu>
> ---
> traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 8bdd6a6..8527808 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -976,7 +976,7 @@ asmlinkage void do_cpu(struct pt_regs *regs)
>
> case 2:
> raw_notifier_call_chain(&cu2_chain, CU2_EXCEPTION, regs);
> - break;
> + return;
>
What happens when the call chain is empty, and the proper action *is*
SIGILL?
David Daney
next prev parent reply other threads:[~2010-06-17 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 13:25 MIPS: return after handling coprocessor 2 exception Jesper Nilsson
2010-06-17 17:13 ` David Daney [this message]
2010-06-17 19:04 ` Jesper Nilsson
2010-06-18 7:54 ` Gleb O. Raiko
2010-06-18 10:00 ` Ralf Baechle
2010-06-18 10:35 ` Gleb O. Raiko
2010-06-18 12:14 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1A57AE.9080706@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=jesper@jni.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox