public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: DDD <dongdong.deng@windriver.com>
To: Greg KH <gregkh@suse.de>
Cc: Greg KH <greg@kroah.com>,
	jason.wessel@windriver.com, galak@kernel.crashing.org,
	bruce.ashfield@windriver.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: cpm_uart: implement the cpm_uart_early_write() function for console poll
Date: Fri, 18 Jun 2010 10:58:22 +0800	[thread overview]
Message-ID: <4C1AE0CE.3040901@windriver.com> (raw)
In-Reply-To: <20100618023758.GA10393@suse.de>

Greg KH wrote:
> On Fri, Jun 18, 2010 at 10:10:48AM +0800, DDD wrote:
>> Greg KH wrote:
>>> On Thu, Jun 17, 2010 at 11:13:40AM +0800, Dongdong Deng wrote:
>>>> The cpm_uart_early_write() function which was used for console poll
>>>> isn't implemented in the cpm uart driver.
>>>>
>>>> Implementing this function both fixes the build and allows
>>>> kgdboc to work via the cpm uart.
>>> So this is needed for the .35 release, right?  Any older kernel releases
>>> as well?
>> Yes, it is needed for the .35 release.
>>
>> The cpm_uart_early_write() of cpm_uart was introduced at 2.6.27,
>> so this patch is needed from 2.6.27.
> 
> So no one has noticed that the driver doesn't build at all since the .27
> kernel release?  Over 2 years?  I hardly think that it's a rush to fix
> it over the next few weeks then :)
>

Hi greg,

The build error just happens when enable the CONFIG_CONSOLE_POLL option.

> I'll go queue it up.

Thanks,

Dongdong

> 
> thanks,
> 
> greg k-h
> 


      reply	other threads:[~2010-06-18  2:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17  3:13 [PATCH] serial: cpm_uart: implement the cpm_uart_early_write() function for console poll Dongdong Deng
2010-06-17 17:31 ` Greg KH
2010-06-18  2:10   ` DDD
2010-06-18  2:37     ` Greg KH
2010-06-18  2:58       ` DDD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1AE0CE.3040901@windriver.com \
    --to=dongdong.deng@windriver.com \
    --cc=bruce.ashfield@windriver.com \
    --cc=galak@kernel.crashing.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=jason.wessel@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox