From: Tejun Heo <tj@kernel.org>
To: Tony Luck <tony.luck@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH UPDATED] sched: adjust when cpu_active and cpuset configurations are updated during cpu on/offlining
Date: Mon, 21 Jun 2010 23:20:12 +0200 [thread overview]
Message-ID: <4C1FD78C.5030600@kernel.org> (raw)
In-Reply-To: <AANLkTil7QBQOsWIWQOGOaAz76eDqx9clZ1CfL2MR5484@mail.gmail.com>
Hello,
On 06/21/2010 11:15 PM, Tony Luck wrote:
> The history is that __exit functions are those that are called on module
> unload. When a driver is built-in to the kernel, it can obviously never
> be unloaded. Therefore the __exit code must just be bloat for the built-in
> case.
I see.
> A system built with CONFIG_HOTPLUG_CPU=n meets the requirement
> that cpus will not be removed after system boot. So why do I need to
> include the __cpuexit code that should only be used to remove cpus?
I'm primarily curious why different archs are doing things
differently, which causes confusion and reduces test coverage. Also,
if you just think about the end result, what x86 is doing makes more
sense. Although it may end up with larger kernel image, it actually
allows more to be dropped once init is complete. Anyways, will send a
patch to change those __cpuexit's to __cpuinit's.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-06-21 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 13:27 [GIT PULL] sched/core: scheduler patches for cmwq Tejun Heo
2010-06-08 19:46 ` [PATCH UPDATED] sched: adjust when cpu_active and cpuset configurations are updated during cpu on/offlining Tejun Heo
2010-06-21 18:28 ` Tony Luck
2010-06-21 20:55 ` Tejun Heo
2010-06-21 21:15 ` Tony Luck
2010-06-21 21:20 ` Tejun Heo [this message]
2010-06-21 21:46 ` Tony Luck
2010-06-21 22:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1FD78C.5030600@kernel.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).