linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Tony Luck <tony.luck@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH UPDATED] sched: adjust when cpu_active and cpuset 	configurations are updated during cpu on/offlining
Date: Tue, 22 Jun 2010 00:02:44 +0200	[thread overview]
Message-ID: <4C1FE184.8050802@kernel.org> (raw)
In-Reply-To: <AANLkTimw9yHxKuclHtZ4UzGtwzc2723IDLwmNguRhnZz@mail.gmail.com>

Hello,

On 06/21/2010 11:46 PM, Tony Luck wrote:
> On Mon, Jun 21, 2010 at 2:20 PM, Tejun Heo <tj@kernel.org> wrote:
>> I'm primarily curious why different archs are doing things
>> differently, which causes confusion and reduces test coverage.  Also,
>> if you just think about the end result, what x86 is doing makes more
>> sense.  Although it may end up with larger kernel image, it actually
>> allows more to be dropped once init is complete.
> 
> It allows x86 to drop some code that it never needed in the first place.
> 
> i don't think that is better :-)
> 
> Maybe someone from x86-land can explain why they *keep* __exit
> code as they are the ones doing it wrong (/me ducks, runs and hides)

Oh, it can actually drop more.  Please consider the following classes.

1. Stuff which are used during system init.
2. Stuff which are used during system init or hotplug.
3. Stuff which are used during hotplug.

ia64 way can express #1 and #3, x86 #1 and #2.  #2 is superset of #3.
So, once init is complete, x86 way can drop larger set.  What matters
is the memory consumption once init is complete, not the image size.
Anyways, in the end, the difference isn't really meaningful but I do
think that it would be far better to have unified behavior across
different architectures, one way or the other.

Thanks.

-- 
tejun

      reply	other threads:[~2010-06-21 22:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04 13:27 [GIT PULL] sched/core: scheduler patches for cmwq Tejun Heo
2010-06-08 19:46 ` [PATCH UPDATED] sched: adjust when cpu_active and cpuset configurations are updated during cpu on/offlining Tejun Heo
2010-06-21 18:28   ` Tony Luck
2010-06-21 20:55     ` Tejun Heo
2010-06-21 21:15       ` Tony Luck
2010-06-21 21:20         ` Tejun Heo
2010-06-21 21:46           ` Tony Luck
2010-06-21 22:02             ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1FE184.8050802@kernel.org \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).