Re: [PATCH V2 1/5] ara virt interface of perf to support kvm guest os statistics collection in guest os

[Avi Kivity <avi@redhat.com>]

On 06/22/2010 01:02 PM, Peter Zijlstra wrote:
> On Tue, 2010-06-22 at 12:53 +0300, Avi Kivity wrote:
>
>
>    
>>> /me has no clue what virtual MSRs are,
>>>        
>> MSRs that are not defined by the hardware, but instead by the
>> hypervisor.
>>
>>      
> Uhm, but the PMU MSRs are all defined by the hardware, if you move the
> PMU MSRs around nothing will work.. *confusion*
>    

You have a set of MSRs for real hardware (actually several sets) 
discoverable by cpuid bits.  You have another set of MSRs, using other 
indexes, discoverable by more CPUID bits.

The new MSR indexes will always #GP on real hardware, but will be 
trapped and serviced by kvm.  In effect kvm will pretend to have a 
hardware-like PMU but done according to its own specifications.

>> When emulating the hardware PMU we can be clever at times and allow
>> RDPMC not to trap.
>>      
> Sure, not disagreeing with that, still the generic case is to trap, so
> lets first get that to work and then try and be smart :-)
>    

That's what we're doing here.

-- 
error compiling committee.c: too many arguments to function