From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542Ab0FWOBH (ORCPT ); Wed, 23 Jun 2010 10:01:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44848 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794Ab0FWOBE (ORCPT ); Wed, 23 Jun 2010 10:01:04 -0400 Message-ID: <4C22132F.4060307@redhat.com> Date: Wed, 23 Jun 2010 16:59:11 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: virtualization@lists.linux-foundation.org, Anthony Liguori , linux-pci@vger.kernel.org, Matt Carlson , linux-kernel@vger.kernel.org, Jesse Barnes , "Rafael J. Wysocki" , Kenji Kaneshige , Tejun Heo , "David S. Miller" , Bjorn Helgaas Subject: Re: [PATCH for-2.6.35] virtio-pci: disable msi at startup References: <20100610152252.GA3510@redhat.com> In-Reply-To: <20100610152252.GA3510@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2010 06:22 PM, Michael S. Tsirkin wrote: > virtio-pci resets the device at startup by writing to the status > register, but this does not clear the pci config space, > specifically msi enable status which affects register > layout. > > This breaks things like kdump when they try to use e.g. virtio-blk. > > Fix by forcing msi off at startup. Since pci.c already has > a routine to do this, we export and use it instead of duplicating code. > > Why doesn't a device reset result in msi being cleared? Shouldn't a reset be equivalent to power cycling? -- error compiling committee.c: too many arguments to function