From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753650Ab0FWPyf (ORCPT ); Wed, 23 Jun 2010 11:54:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6948 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275Ab0FWPye (ORCPT ); Wed, 23 Jun 2010 11:54:34 -0400 Message-ID: <4C222E0A.8060803@redhat.com> Date: Wed, 23 Jun 2010 18:53:46 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: virtualization@lists.linux-foundation.org, Anthony Liguori , linux-pci@vger.kernel.org, Matt Carlson , linux-kernel@vger.kernel.org, Jesse Barnes , "Rafael J. Wysocki" , Kenji Kaneshige , Tejun Heo , "David S. Miller" , Bjorn Helgaas Subject: Re: [PATCH for-2.6.35] virtio-pci: disable msi at startup References: <20100610152252.GA3510@redhat.com> <4C22132F.4060307@redhat.com> <20100623135946.GA30526@redhat.com> <4C221871.6020509@redhat.com> <20100623144307.GB30526@redhat.com> <4C222508.2060804@redhat.com> <20100623152633.GC30526@redhat.com> <4C2229DB.6060706@redhat.com> <20100623154311.GD30526@redhat.com> In-Reply-To: <20100623154311.GD30526@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/23/2010 06:43 PM, Michael S. Tsirkin wrote: > > >>> If/when we use more registers, we can update driver to clear them on start. >>> >>> >> The kdump kernel may not load drivers for those extra devices. >> > Then we don't care about clearing them? > We do, if the device has a side effect (like blasting out noise through loudspeakers). Anyway, just a suggestion. -- error compiling committee.c: too many arguments to function