From: Randy Dunlap <randy.dunlap@oracle.com>
To: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
gregkh@suse.de, devel@driverdev.osuosl.org,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for June 21 (staging/easycap)
Date: Wed, 23 Jun 2010 11:06:30 -0700 [thread overview]
Message-ID: <4C224D26.1020307@oracle.com> (raw)
In-Reply-To: <20100622223612.GB3898@kroah.com>
Greg KH wrote:
> On Mon, Jun 21, 2010 at 09:00:49AM -0700, Randy Dunlap wrote:
>> On Mon, 21 Jun 2010 17:00:56 +1000 Stephen Rothwell wrote:
>>
>>> Hi all,
>>>
>>> Changes since 20100618:
>>
>> When CONFIG_USB is not enabled:
>>
>> ERROR: "usb_kill_urb" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_deregister_dev" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "video_register_device" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_deregister" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "video_unregister_device" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_set_interface" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_register_dev" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_control_msg" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_submit_urb" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_get_dev" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_find_interface" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_register_driver" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_free_urb" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "usb_alloc_urb" [drivers/staging/easycap/easycap.ko] undefined!
>>
>>
>> Adding "depends on USB" to EASYCAP is a good start.
>> After that and enabling CONFIG_USB, build of easycap gets:
>>
>> ERROR: "video_register_device" [drivers/staging/easycap/easycap.ko] undefined!
>> ERROR: "video_unregister_device" [drivers/staging/easycap/easycap.ko] undefined!
>>
>> because there is no media/video support enabled. Also no SOUND enabled,
>> so I expect there to be build errors associated with sound also, meaning that
>> the Kconfig file should probably modified with something like
>>
>> config EASYCAP
>> + depends on USB && VIDEO_DEV && SND
>>
>>
>> This is something that the driver author should know the answer to and submit a
>> patch for.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> You are right, care to make up a patch for this?
No thanks, please see my last statement above.
IOW, I want the driver developer (not you) to act responsibly on this.
next prev parent reply other threads:[~2010-06-23 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 7:00 linux-next: Tree for June 21 Stephen Rothwell
2010-06-21 16:00 ` linux-next: Tree for June 21 (staging/easycap) Randy Dunlap
2010-06-22 22:36 ` Greg KH
2010-06-23 18:06 ` Randy Dunlap [this message]
2010-06-23 22:09 ` Greg KH
2010-06-22 5:25 ` -next June 21: WARNING: at include/linux/tty.h Sachin Sant
2010-06-23 6:55 ` Stephen Rothwell
2010-06-23 7:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C224D26.1020307@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).