public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockrwd@gmail.com>
To: "Ozan Çağlayan" <ozan@pardus.org.tr>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>,
	Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: Ubuntu patch enabling speedstep for sonoma processors
Date: Thu, 24 Jun 2010 18:29:32 -0600	[thread overview]
Message-ID: <4C23F86C.5090502@gmail.com> (raw)
In-Reply-To: <4C237EAE.3000908@pardus.org.tr>

On 06/24/2010 09:50 AM, Ozan Çağlayan wrote:
> Hi,
>
> The following patch enables speedstep for sonoma processors:
> http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-maverick.git;a=blobdiff;f=arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c;h=ee4e9f8050752923f9671f61ffbea662bc9ad12a;hp=9b1ff37de46ae6a729f48d2d94ad30548806884d;hb=23120eb5ae5a12924565e8af3d946a015e1caaf9;hpb=215cc71ef0b26b9434404f387681d9bd173d2434
>
> The patch never got accepted by upstream after some discussions:
>
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2008-06/msg01078.html
>
> """
> This patch has been floating around for years.
> So long, I've forgotten the original reason it wasn't accepted.
> It had something to do with it working for some users, but not others,
> and we can't detect the 'not working' case.
>
> speedstep-centrino is also deprecated in favour of acpi-cpufreq for some time.
> If acpi isn't working on these machines, we should find out why.
>
> Dave Jones
> """
>
> """
> My recollection is that we had no way to work out which voltage table
> was appropriate for a given CPU, so there was a risk of us either over-
> or under-volting the chip. Doing it via ACPI is safe.
>
> Matthew Garrett
> """
>
> I have bug report from a user which complains that frequency scaling is not available
> on its computer. This patch fixes the issue but seen the discussions there should be a
> better and more correct way to fix the issue.
>
> What should I do in order to debug and try to fix it?
>
> And also seen that Ubuntu carries this patch for a relatively long time, did you see
> any negative effect like the aforementioned risk of over/under-volting the chip?

The acpidump from that system would be a good start, to figure out why 
acpi-cpufreq isn't working..

      reply	other threads:[~2010-06-25  0:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-24 15:50 Ubuntu patch enabling speedstep for sonoma processors Ozan Çağlayan
2010-06-25  0:29 ` Robert Hancock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C23F86C.5090502@gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=kernel-team@lists.ubuntu.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ozan@pardus.org.tr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox