From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753812Ab0F2IfG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Jun 2010 04:35:06 -0400
Received: from daytona.panasas.com ([67.152.220.89]:58043 "EHLO
	daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752883Ab0F2IfE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Jun 2010 04:35:04 -0400
Message-ID: <4C29B034.8070208@panasas.com>
Date: Tue, 29 Jun 2010 11:35:00 +0300
From: Boaz Harrosh <bharrosh@panasas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4
MIME-Version: 1.0
To: Liu Aleaxander <aleaxander@gmail.com>
CC: Jeff Dike <jdike@addtoit.com>, user-mode-linux-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [uml-devel] [PATCH] um: Include missing header file in 	os-linux/mem.c
References: <AANLkTikziSEDW07YiiJs6ny6JLhSQ-TGvdw_kTroIIx5@mail.gmail.com>	<4C1809D3.7030707@panasas.com> <AANLkTikYn_EwizmUq6ZxitJ6ibCkr8Nfd4yslK_Bo0zR@mail.gmail.com>
In-Reply-To: <AANLkTikYn_EwizmUq6ZxitJ6ibCkr8Nfd4yslK_Bo0zR@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 29 Jun 2010 08:35:03.0529 (UTC) FILETIME=[F84F8D90:01CB1765]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/15/2010 11:06 AM, Liu Aleaxander wrote:
> The os-linux/mem.c file calls fchmod function, which is declared in sys/stat.h
> header file, so include it.
> 
> Signed-off-by: Liu Aleaxander <Aleaxander@gmail.com>
> ---
>  arch/um/os-Linux/mem.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c
> index 93a11d7..e696144 100644
> --- a/arch/um/os-Linux/mem.c
> +++ b/arch/um/os-Linux/mem.c
> @@ -10,6 +10,7 @@
>  #include <errno.h>
>  #include <fcntl.h>
>  #include <string.h>
> +#include <sys/stat.h>
>  #include <sys/mman.h>
>  #include <sys/param.h>
>  #include "init.h"
> 

On 06/15/2010 04:06 AM, Liu Aleaxander wrote:
> On Wed, Jun 16, 2010 at 7:16 AM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>>
>> Yes. I have the same patch.
>>
>> Apparently it's new for Fedora 13. Previous Fedora's are compiling fine.
> 
> Same here:)
> 
>> I guess something has changed with the new gcc headers include sequence
> 

Andrew? Jeff? someone?

I saw that some uml patches where pushed for -rc4. What about this patch?
could some one push this patch? It's for FC13 compilation?

It might be needed for stable@ as well. I'll try to test with old Kernels.
Am back on an FC12 in the office so it'll take some time.

Liu could you test to see that older Kernels need this patch as well?

Thanks
Boaz