From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: [PATCH] KVM: IOAPIC: only access APIC registers one dword at a time
Date: Fri, 02 Jul 2010 12:38:35 +0800 [thread overview]
Message-ID: <4C2D6D4B.5060309@cn.fujitsu.com> (raw)
The IOAPIC spec says:
When accessing these registers, accesses must be done one dword at a time.
For example, software should never access byte 2 from the Data register before
accessing bytes 0 and 1. The hardware will not attempt to recover from a bad
programming model in this case.
So, this patch removes other width access
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
virt/kvm/ioapic.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
index 1149c60..f96816f 100644
--- a/virt/kvm/ioapic.c
+++ b/virt/kvm/ioapic.c
@@ -306,14 +306,10 @@ static int ioapic_mmio_read(struct kvm_io_device *this, gpa_t addr, int len,
spin_unlock(&ioapic->lock);
switch (len) {
- case 8:
- *(u64 *) val = result;
- break;
- case 1:
- case 2:
case 4:
- memcpy(val, (char *)&result, len);
+ *(u32 *) val = result;
break;
+
default:
printk(KERN_WARNING "ioapic: wrong length %d\n", len);
}
@@ -332,7 +328,7 @@ static int ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
(void*)addr, len, val);
ASSERT(!(addr & 0xf)); /* check alignment */
- if (len == 4 || len == 8)
+ if (len == 4)
data = *(u32 *) val;
else {
printk(KERN_WARNING "ioapic: Unsupported size %d\n", len);
--
1.6.1.2
next reply other threads:[~2010-07-02 4:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 4:38 Xiao Guangrong [this message]
2010-07-02 7:31 ` [PATCH] KVM: IOAPIC: only access APIC registers one dword at a time Jin Dongming
2010-07-02 7:38 ` Xiao Guangrong
2010-07-02 8:00 ` [PATCH v2] " Xiao Guangrong
2010-07-02 17:42 ` Marcelo Tosatti
2010-07-03 8:20 ` Xiao Guangrong
2010-07-03 10:11 ` Avi Kivity
2010-07-05 3:47 ` Xiao Guangrong
2010-07-05 6:23 ` Gleb Natapov
2010-07-05 7:54 ` Avi Kivity
2010-07-05 7:56 ` Xiao Guangrong
2010-07-05 8:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2D6D4B.5060309@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox