From: Paolo Bonzini <pbonzini@redhat.com>
To: stefano@stabellini.net
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
Stefano.Stabellini@eu.citrix.com, sheng@linux.intel.com,
ddutile@redhat.com, jeremy@goop.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 10/13] Do not try to disable hpet if it hasn't been initialized before
Date: Fri, 02 Jul 2010 12:44:55 +0200 [thread overview]
Message-ID: <4C2DC327.1090007@redhat.com> (raw)
In-Reply-To: <1277136847-13266-10-git-send-email-stefano@stabellini.net>
On 06/21/2010 06:14 PM, stefano@stabellini.net wrote:
> - if (is_hpet_capable()) {
> - unsigned int cfg = hpet_readl(HPET_CFG);
> + unsigned int cfg;
You changed this earlier from unsigned long to unsigned int, but it is
wrong (though it works because bits 32-63 of the HPET_CFG register are
unused). Can you please make a note to change it back sometime?
Thanks,
Paolo
next prev parent reply other threads:[~2010-07-02 10:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 16:12 [PATCH 0/12] PV on HVM Xen Stefano Stabellini
2010-06-21 16:13 ` [PATCH 01/13] Add support for hvm_op stefano
2010-06-21 16:13 ` [PATCH 02/13] early PV on HVM stefano
2010-06-21 16:13 ` [PATCH 03/13] evtchn delivery " stefano
2010-06-21 16:13 ` [PATCH 04/13] Xen PCI platform device driver stefano
2010-06-30 17:55 ` Konrad Rzeszutek Wilk
2010-07-01 11:38 ` Stefano Stabellini
2010-06-21 16:13 ` [PATCH 05/13] Add suspend\resume support for PV on HVM guests stefano
2010-06-21 16:14 ` [PATCH 06/13] Allow xen platform pci device to be compiled as a module stefano
2010-06-21 16:14 ` [PATCH 0/12] PV on HVM Xen Stefano Stabellini
2010-06-21 16:14 ` [PATCH 07/13] Fix find_unbound_irq in presence of ioapic irqs stefano
2010-06-21 16:14 ` [PATCH 08/13] Fix possible NULL pointer dereference in print_IO_APIC stefano
2010-06-21 16:14 ` [PATCH 09/13] __setup_vector_irq: handle NULL chip_data stefano
2010-06-21 16:14 ` [PATCH 10/13] Do not try to disable hpet if it hasn't been initialized before stefano
2010-06-30 17:53 ` Konrad Rzeszutek Wilk
2010-07-09 1:05 ` john stultz
2010-06-30 21:24 ` Venkatesh Pallipadi
2010-07-02 10:44 ` Paolo Bonzini [this message]
2010-06-21 16:14 ` [PATCH 11/13] Use xen_vcpuop_clockevent, xen_clocksource and xen wallclock stefano
2010-07-01 19:41 ` Don Dutile
2010-07-02 17:17 ` Stefano Stabellini
2010-06-21 16:14 ` [PATCH 12/13] Unplug emulated disks and nics stefano
2010-07-01 19:41 ` Don Dutile
2010-07-05 11:58 ` Stefano Stabellini
2010-07-07 20:01 ` Don Dutile
2010-07-08 13:13 ` Stefano Stabellini
2010-07-08 19:57 ` [Xen-devel] " Don Dutile
2010-07-08 21:29 ` Ian Campbell
2010-07-08 21:59 ` Don Dutile
2010-07-09 8:02 ` Ian Campbell
2010-07-09 10:54 ` Stefano Stabellini
2010-07-09 13:42 ` Don Dutile
2010-06-21 16:14 ` [PATCH 13/13] Call HVMOP_pagetable_dying on exit_mmap stefano
2010-06-30 17:56 ` [PATCH 0/12] PV on HVM Xen Konrad Rzeszutek Wilk
2010-07-01 11:38 ` Stefano Stabellini
2010-07-01 19:43 ` [Xen-devel] " Dan Magenheimer
2010-07-02 10:43 ` Stefano Stabellini
2010-07-02 16:08 ` Dan Magenheimer
2010-07-02 17:14 ` Stefano Stabellini
2010-07-02 19:49 ` Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2DC327.1090007@redhat.com \
--to=pbonzini@redhat.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=ddutile@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=stefano@stabellini.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).