Re: [PATCH v4 5/6] KVM: MMU: combine guest pte read between walk and pte prefetch

Avi Kivity
2010-07-04T14:32:06Z

On 07/03/2010 03:57 PM, Xiao Guangrong wrote:
>
> Avi Kivity wrote:
>
>
>>> And this check is not sufficient, since it's only checked if the
>>> mapping is zapped or not exist, for other words only when broken this
>>> judgment:
>>> is_shadow_present_pte(*sptep)&& !is_large_pte(*sptep)
>>>
>>> but if the middle level is present and it's not the large mapping,
>>> this check is skipped.
>>>
>>>
>>
>> Well, in the description, it looked like everything was using small
>> pages (in kvm, level=1 means PTE level, we need to change this one
>> day). Please describe again and say exactly when the guest or host uses
>> large pages.
>>
>>
> Avi, sorry for my poor English, i not mean "everything was using small", i don't
> know where cause you confused :-(
>

Well, LVL1 got me to assume those are small pages.

Can you explain more precisely? Use the processor terms like PTE and
PDE. Don't worry about your English :)

--
error compiling committee.c: too many arguments to function