Re: [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF

Xiao Guangrong
2010-07-06T00:53:56Z

Marcelo Tosatti wrote:
> On Sat, Jul 03, 2010 at 04:08:42PM +0800, Xiao Guangrong wrote:
>>
>> Marcelo Tosatti wrote:
>>
>>>> +
>>>> + if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL))
>>>> + break;
>>> BTW, doesnt sync_page also lack reserved bit checking? (unrelated to
>>> this patch).
>>>
>> I think it's not since if EPT is enabled, no unsync page exist, the sync page
>> path can't be trigged. :-)
>
> What i mean is, why the sync_page path does not require reserved bit
> checking? (EPT disabled).
>

Oh, i think we should check it, i'll post a patch to fix it.