Re: [PATCH v4 1/6] KVM: MMU: introduce gfn_to_pfn_atomic() function

Nick Piggin
2010-07-03T03:13:10Z

On Fri, Jul 02, 2010 at 01:47:56PM -0300, Marcelo Tosatti wrote:
> On Thu, Jul 01, 2010 at 09:53:04PM +0800, Xiao Guangrong wrote:
> > Introduce gfn_to_pfn_atomic(), it's the fast path and can used in atomic
> > context, the later patch will use it
> >
> > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> > ---
> > arch/x86/mm/gup.c | 2 ++
> > include/linux/kvm_host.h | 1 +
> > virt/kvm/kvm_main.c | 32 +++++++++++++++++++++++++-------
> > 3 files changed, 28 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/x86/mm/gup.c b/arch/x86/mm/gup.c
> > index 738e659..0c9034b 100644
> > --- a/arch/x86/mm/gup.c
> > +++ b/arch/x86/mm/gup.c
> > @@ -6,6 +6,7 @@
> > */
> > #include <linux/sched.h>
> > #include <linux/mm.h>
> > +#include <linux/module.h>
> > #include <linux/vmstat.h>
> > #include <linux/highmem.h>
> >
> > @@ -274,6 +275,7 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
> >
> > return nr;
> > }
> > +EXPORT_SYMBOL_GPL(__get_user_pages_fast);
> >
> > /**
> > * get_user_pages_fast() - pin user pages in memory
>
> This should be a separate patch (overlooked that before). Ingo, Nick,
> can this go in through the kvm tree?

I'm happy for it to be exported. Yes put it in a seperate patch and
add an acked-by: me on it please. Beyond that I don't care what tree
it goes through :) although Ingo might have an opinion