Re: [PATCH v4 5/6] KVM: MMU: combine guest pte read between walk and pte prefetch

Xiao Guangrong
2010-07-05T09:35:43Z

Avi Kivity wrote:

>
> Note: I think we have to check _after_ kvm_mmu_get_page(), otherwise we
> might be checking a page that is not write-protected and can change again.
>
> So the logic needs to be something like
>
> for_each_shadow_entry:
> if (!last_level && !present(*spte))
> kvm_mmu_get_page
> verify gpte
> if (last_level)
> mmu_set_spte()
>

Agree! Will do it.