From: Jens Axboe <axboe@kernel.dk>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] remove q->prepare_flush_fn hook
Date: Mon, 05 Jul 2010 10:03:12 +0200 [thread overview]
Message-ID: <4C3191C0.1080406@kernel.dk> (raw)
In-Reply-To: <20100705170050Z.fujita.tomonori@lab.ntt.co.jp>
On 2010-07-05 10:01, FUJITA Tomonori wrote:
> On Mon, 05 Jul 2010 08:55:36 +0200
> Jens Axboe <axboe@kernel.dk> wrote:
>
>> On 2010-07-03 10:45, FUJITA Tomonori wrote:
>>> This removes q->prepare_flush_fn. Except for ide and scsi, all the
>>> users just mark flush requests. They can use REQ_FLUSH flag
>>> instead.
>>>
>>> SCSI and ide can use q->prep_rq_fn to build flush requests.
>>>
>>> This can be applied to the block's for-2.6.36.
>>
>> Thanks, applied.
>
> Thanks,
>
> looks like you applied the patches in a wrong order (breaks bisect).
>
> At least, the first two patches need to be applied in order before the
> rest:
>
> [PATCH 1/9] block: introduce REQ_FLUSH flag
> [PATCH 2/9] block: permit PREFLUSH and POSTFLUSH without prepare_flush_fn
Funky, my patch script must have shuffled them, that was definitely
not on purpose. Guess I'll have to rebase to fix that up...
--
Jens Axboe
next prev parent reply other threads:[~2010-07-05 8:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 8:45 [PATCH 0/9] remove q->prepare_flush_fn hook FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 1/9] block: introduce REQ_FLUSH flag FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 2/9] block: permit PREFLUSH and POSTFLUSH without prepare_flush_fn FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 3/9] scsi: stop using q->prepare_flush_fn FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 4/9] osdblk: " FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 5/9] ps3disk: " FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 6/9] dm: " FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 7/9] virtio_blk: " FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 8/9] ide: " FUJITA Tomonori
2010-07-03 16:48 ` David Miller
2010-07-03 8:45 ` [PATCH 9/9] block: remove q->prepare_flush_fn completely FUJITA Tomonori
2010-07-03 10:13 ` Christoph Hellwig
2010-07-03 10:02 ` [PATCH 0/9] remove q->prepare_flush_fn hook Christoph Hellwig
2010-07-05 6:55 ` Jens Axboe
2010-07-05 8:01 ` FUJITA Tomonori
2010-07-05 8:03 ` Jens Axboe [this message]
2010-07-07 19:52 ` Christoph Hellwig
2010-07-07 23:54 ` FUJITA Tomonori
2010-07-07 23:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3191C0.1080406@kernel.dk \
--to=axboe@kernel.dk \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox