Re: [PATCH] Packet hub driver of Topcliff PCH

[Randy Dunlap <randy.dunlap@oracle.com>]

On 07/05/10 00:20, Masayuki Ohtak wrote:
> Hi Randy
> 
> I have modified for your comments.
> Please confirm below.

Agreed, thanks for the updates.

> Thanks, Ohtake.
> 
> ---
> 
> Packet hub driver of Topcliff PCH
> 
> Topcliff PCH is the platform controller hub that is going to be used in
> Intel's upcoming general embedded platform. All IO peripherals in
> Topcliff PCH are actually devices sitting on AMBA bus. Packet hub is
> a special converter device in Topcliff PCH that translate AMBA transactions
> to PCI Express transactions and vice versa. Thus packet hub helps present
> all IO peripherals in Topcliff PCH as PCIE devices to IA system.
> Topcliff PCH has MAC address and Option ROM data.
> These data are in SROM which is connected to PCIE bus.
> Packet hub driver of Topcliff PCH can access MAC address and Option ROM data in
> SROM.
> 
> Signed-off-by: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> ---
>  Documentation/ioctl/ioctl-number.txt |    1 +
>  drivers/char/Kconfig                 |    9 +
>  drivers/char/Makefile                |    2 +
>  drivers/char/pch_phub/Makefile       |    3 +
>  drivers/char/pch_phub/pch_phub.c     |  803 ++++++++++++++++++++++++++++++++++
>  drivers/char/pch_phub/pch_phub.h     |   48 ++
>  6 files changed, 866 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/char/pch_phub/Makefile
>  create mode 100755 drivers/char/pch_phub/pch_phub.c
>  create mode 100755 drivers/char/pch_phub/pch_phub.h
> 
> diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt
> index 35cf64d..b700b17 100644
> --- a/Documentation/ioctl/ioctl-number.txt
> +++ b/Documentation/ioctl/ioctl-number.txt
> @@ -320,4 +320,5 @@ Code  Seq#(hex)	Include File		Comments
>  					<mailto:thomas@winischhofer.net>
>  0xF4	00-1F	video/mbxfb.h		mbxfb
>  					<mailto:raph@8d.com>
> +0xF7	00-0F	drivers/char/pch_phub/pch_phub.h	PCH Phub driver
>  0xFD	all	linux/dm-ioctl.h



-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***