From: Yinghai Lu <yinghai@kernel.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Ram Pai <linuxram@us.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
clemens@ladisch.de
Subject: Re: [RFC PATCH 1/1] PCI: skip release and reallocation of io port resources
Date: Tue, 06 Jul 2010 16:13:07 -0700 [thread overview]
Message-ID: <4C33B883.6010206@kernel.org> (raw)
In-Reply-To: <20100702143515.2896d728@virtuousgeek.org>
On 07/02/2010 02:35 PM, Jesse Barnes wrote:
> On Wed, 30 Jun 2010 16:59:49 -0700
> Ram Pai <linuxram@us.ibm.com> wrote:
>
>> On Wed, Jun 30, 2010 at 04:10:26PM -0700, Linus Torvalds wrote:
>>> On Wed, Jun 30, 2010 at 2:15 PM, Ram Pai <linuxram@us.ibm.com> wrote:
>>>> PCI: skip release and reallocation of io port resources
>>>
>>> Gaah. This still looks like just total ad-hoc hackery. The logic for
>>> it all seems very fragile, just a random case made up from the one
>>> failing issue. There's no underlying logic or design to it.
>>>
>>> I still think that we should just make people explicitly ask for a
>>> blank slate if the bios allocations don't work out.
>>
>> and interactively allocate resource?
>
> No I don't think we want to add any prompts to the kernel boot
> process. :)
>
>>> Rather than trying
>>> to fix it up automatically, which has been a total rats nest of random
>>> crud.
>>
>> Can Yinghai Lu's patch 'pci=try=' be some temporary middle ground till
>> a more elaborate patch is found?
>>
>> His suggestion partly meets your suggestion. It does not automatically
>> reassign unless the user explicitly asks for it. Hence should not
>> break any working systems, at the same time can handle system like
>> mine.
>
> pci=try just doesn't communicate much, it should be something like
> pci=override_bios and do as Linus suggests.
So you want to use pci=override_bios to reallocate all bios assigned resource include
peer root buses resources and pci bridge resource and pci devices BAR?
in that case, we may need to update
1. io apic related BAR to be consistent with io apic addr from MADT.
2. other ACPI related tables like return for _CRS...
or just change pci=try to pci=override_bios in my patch?
>
> But we should continue to shoot for not ever having to use that option
> on normal systems.
>
replacing legacy bios with linuxbios is cleanest way.
Yinghai
next prev parent reply other threads:[~2010-07-06 23:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 21:15 [RFC PATCH 1/1] PCI: skip release and reallocation of io port resources Ram Pai
2010-06-30 22:59 ` Yinghai Lu
2010-06-30 23:10 ` Linus Torvalds
2010-06-30 23:59 ` Ram Pai
2010-07-02 21:35 ` Jesse Barnes
2010-07-06 23:13 ` Yinghai Lu [this message]
2010-07-06 23:58 ` Linus Torvalds
2010-07-07 0:49 ` Yinghai Lu
2010-07-07 4:28 ` Andrew Hendry
2010-07-07 18:35 ` Jesse Barnes
2010-07-07 18:55 ` Suresh Siddha
2010-07-08 13:26 ` Andrew Hendry
2010-07-09 15:25 ` Jesse Barnes
2010-07-09 15:50 ` Bjorn Helgaas
2010-07-09 16:00 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C33B883.6010206@kernel.org \
--to=yinghai@kernel.org \
--cc=clemens@ladisch.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox