From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754803Ab0GHUGE (ORCPT ); Thu, 8 Jul 2010 16:06:04 -0400 Received: from vms173019pub.verizon.net ([206.46.173.19]:53686 "EHLO vms173019pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217Ab0GHUGD (ORCPT ); Thu, 8 Jul 2010 16:06:03 -0400 Message-id: <4C362FA7.807@acm.org> Date: Thu, 08 Jul 2010 15:05:59 -0500 From: Corey Minyard User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4 MIME-version: 1.0 To: "Justin P. Mattock" Cc: akpm@linux-foundation.org, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, sftp.mtuci@gmail.com Subject: Re: [PATCH]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used References: <1278616195-3158-1-git-send-email-justinmattock@gmail.com> In-reply-to: <1278616195-3158-1-git-send-email-justinmattock@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good to me: Acked-by: Corey Minyard On 07/08/2010 02:09 PM, Justin P. Mattock wrote: > The below patch fixes a warning message generated by GCC, and also > updates a web address pointing to a pdf containging information. > CC [M] drivers/char/ipmi/ipmi_si_intf.o > drivers/char/ipmi/ipmi_si_intf.c: In function 'try_init_spmi': > drivers/char/ipmi/ipmi_si_intf.c:2016:8: warning: variable 'addr_space' set but not used > > Signed-off-by: Sergey V. > Signed-off-by: Justin P. Mattock > > --- > drivers/char/ipmi/ipmi_si_intf.c | 10 ++-------- > 1 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 094bdc3..7e40d02 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -1965,8 +1965,8 @@ static int acpi_gpe_irq_setup(struct smi_info *info) > > /* > * Defined at > - * http://h21007.www2.hp.com/dspp/files/unprotected/devresource/ > - * Docs/TechPapers/IA64/hpspmi.pdf > + * http://h21007.www2.hp.com/portal/download/files > + * /unprot/hpspmi.pdf > */ > struct SPMITable { > s8 Signature[4]; > @@ -2013,18 +2013,12 @@ struct SPMITable { > static __devinit int try_init_spmi(struct SPMITable *spmi) > { > struct smi_info *info; > - u8 addr_space; > > if (spmi->IPMIlegacy != 1) { > printk(KERN_INFO PFX "Bad SPMI legacy %d\n", spmi->IPMIlegacy); > return -ENODEV; > } > > - if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) > - addr_space = IPMI_MEM_ADDR_SPACE; > - else > - addr_space = IPMI_IO_ADDR_SPACE; > - > info = kzalloc(sizeof(*info), GFP_KERNEL); > if (!info) { > printk(KERN_ERR PFX "Could not allocate SI data (3)\n"); >