public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: mmu notifier calls in apply_to_page_range()
Date: Fri, 09 Jul 2010 08:06:20 -0700	[thread overview]
Message-ID: <4C373AEC.6000502@goop.org> (raw)

I just noticed that the original mmu notifier change (cddb8a5c14a) adds
calls to mmu_notifier_invalidate_range_start/end to
apply_to_page_range().  This doesn't seem correct to me, since
apply_to_page_range can perform arbitrary operations to the range of
pages, not just invalidation of the pages.  It seems to me that the
appropriate mmu notifiers should be called either around the call to
apply_to_page_range(), or from within the callback function.

Andrea, what's the rationale for mmu_notifier_invalidate_range_start/end
here?

Thanks,
    J

             reply	other threads:[~2010-07-09 15:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-09 15:06 Jeremy Fitzhardinge [this message]
2010-07-09 15:12 ` mmu notifier calls in apply_to_page_range() Andrea Arcangeli
2010-07-09 15:51   ` Jeremy Fitzhardinge
2010-07-09 16:22     ` Andrea Arcangeli
2010-07-09 17:30       ` Jeremy Fitzhardinge
2010-07-09 17:36         ` Andrea Arcangeli
2010-07-09 17:41           ` Jeremy Fitzhardinge
2010-07-09 18:31             ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C373AEC.6000502@goop.org \
    --to=jeremy@goop.org \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox