public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* i915 boot regression on Q35 chipset with 2.6.35-rc4
@ 2010-07-09 20:48 Tim Gardner
  2010-07-09 23:52 ` Woody Suwalski
  2010-07-26 18:23 ` Eric Anholt
  0 siblings, 2 replies; 10+ messages in thread
From: Tim Gardner @ 2010-07-09 20:48 UTC (permalink / raw)
  To: airlied; +Cc: linux-kernel@vger.kernel.org, Kees Cook, chris, eric, jbarnes

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Dave,

Please find attached a patch that fixes a boot time regression caused by 
commit f1befe71fa7a79ab733011b045639d8d809924ad. It has been reported to 
fix at least one user's boot problems.

I think it is also likely the source of the problems reported in 
http://marc.info/?l=linux-kernel&m=127869783002454&w=2

rtg
-- 
Tim Gardner tim.gardner@canonical.com

[-- Attachment #2: 0001-UBUNTU-Upstream-i915-Use-the-correct-mask-to-detect-.patch --]
[-- Type: text/x-patch, Size: 2179 bytes --]

>From e025bfb96059be648074a02f60dff92fb658cb9a Mon Sep 17 00:00:00 2001
From: Tim Gardner <tim.gardner@canonical.com>
Date: Fri, 9 Jul 2010 11:14:41 -0600
Subject: [PATCH] i915: Use the correct mask to detect i830 aperture size.

BugLink: https://bugs.launchpad.net/bugs/597075

commit f1befe71fa7a79ab733011b045639d8d809924ad introduced a regression when
detecting aperture size of some i915 adapters, e.g., those on the
Intel Q35 chipset.

The original report: https://bugzilla.kernel.org/show_bug.cgi?id=15733
The regression report: https://bugzilla.kernel.org/show_bug.cgi?id=16294

According to the specification found at http://intellinuxgraphics.org/VOL_1_graphics_core.pdf,
the PCI config space register I830_GMCH_CTRL is a mirror of GMCH Graphics Control. The correct
macro for isolating the aperture size bits is therefore I830_GMCH_GMS_MASK along with the
attendant changes to the case statement.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Tested-by: Kees Cook <kees.cook@canonical.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Eric Anholt <eric@anholt.net>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/char/agp/intel-gtt.c |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
index 9344216..a754715 100644
--- a/drivers/char/agp/intel-gtt.c
+++ b/drivers/char/agp/intel-gtt.c
@@ -1216,17 +1216,20 @@ static int intel_i915_get_gtt_size(void)
 
 		/* G33's GTT size defined in gmch_ctrl */
 		pci_read_config_word(agp_bridge->dev, I830_GMCH_CTRL, &gmch_ctrl);
-		switch (gmch_ctrl & G33_PGETBL_SIZE_MASK) {
-		case G33_PGETBL_SIZE_1M:
+		switch (gmch_ctrl & I830_GMCH_GMS_MASK) {
+		case I830_GMCH_GMS_STOLEN_512:
+			size = 512;
+			break;
+		case I830_GMCH_GMS_STOLEN_1024:
 			size = 1024;
 			break;
-		case G33_PGETBL_SIZE_2M:
-			size = 2048;
+		case I830_GMCH_GMS_STOLEN_8192:
+			size = 8*1024;
 			break;
 		default:
 			dev_info(&agp_bridge->dev->dev,
 				 "unknown page table size 0x%x, assuming 512KB\n",
-				(gmch_ctrl & G33_PGETBL_SIZE_MASK));
+				(gmch_ctrl & I830_GMCH_GMS_MASK));
 			size = 512;
 		}
 	} else {
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* re: i915 boot regression on Q35 chipset with 2.6.35-rc4
@ 2010-07-21 12:35 Tim Gardner
  2010-07-21 13:37 ` Chris Wilson
  2010-07-21 20:30 ` Dave Airlie
  0 siblings, 2 replies; 10+ messages in thread
From: Tim Gardner @ 2010-07-21 12:35 UTC (permalink / raw)
  To: Dave Airlie; +Cc: chris, jbarnes, eric, Kees Cook, linux-kernel

Dave,

http://lkml.org/lkml/2010/7/9/287

What's up with this patch? I haven't received any comment, nor has it 
appeared in your git repository.

rtg
-- 
Tim Gardner tim.gardner@canonical.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-07-26 18:23 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-09 20:48 i915 boot regression on Q35 chipset with 2.6.35-rc4 Tim Gardner
2010-07-09 23:52 ` Woody Suwalski
2010-07-26 18:23 ` Eric Anholt
  -- strict thread matches above, loose matches on Subject: below --
2010-07-21 12:35 Tim Gardner
2010-07-21 13:37 ` Chris Wilson
2010-07-21 14:22   ` Tim Gardner
2010-07-22  9:19   ` Jin, Gordon
2010-07-22 13:57     ` Jiri Slaby
2010-07-22 23:59   ` Jin, Gordon
2010-07-21 20:30 ` Dave Airlie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox