From: "H. Peter Anvin" <hpa@zytor.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [RFC/PATCH] x86: Early-boot serial I/O support
Date: Sat, 10 Jul 2010 11:51:52 -0700 [thread overview]
Message-ID: <4C38C148.2060805@zytor.com> (raw)
In-Reply-To: <1278785277-22629-1-git-send-email-penberg@cs.helsinki.fi>
On 07/10/2010 11:07 AM, Pekka Enberg wrote:
> This patch adds serial I/O support to very early boot printf(). It's useful for
> debugging boot code when running Linux under KVM, for example. The actual code
> was lifted from early printk.
Yinghai is correct that this really needs to pick apart the command
line, especially since there is already support for command-line parsing
in the early boot code. I suggest we just reuse the earlyprintk=
option, especially since it's basically the same code and so should have
the same failure profile.
> +
> + while ((inb(early_serial_base + LSR)& XMTRDY) == 0&& --timeout)
> + ;
> +
cpu_relax(); here, probably.
-hpa
next prev parent reply other threads:[~2010-07-10 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 18:07 [RFC/PATCH] x86: Early-boot serial I/O support Pekka Enberg
2010-07-10 18:38 ` Yinghai Lu
2010-07-10 18:51 ` H. Peter Anvin [this message]
2010-07-10 21:18 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C38C148.2060805@zytor.com \
--to=hpa@zytor.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@cs.helsinki.fi \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox