From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753125Ab0GJViA (ORCPT ); Sat, 10 Jul 2010 17:38:00 -0400 Received: from terminus.zytor.com ([198.137.202.10]:54087 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669Ab0GJVh7 (ORCPT ); Sat, 10 Jul 2010 17:37:59 -0400 Message-ID: <4C38E7FD.9020403@zytor.com> Date: Sat, 10 Jul 2010 14:37:01 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: Cyrill Gorcunov CC: Pekka Enberg , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Yinghai Lu Subject: Re: [PATCH v2] x86: Early-boot serial I/O support References: <1278790820-1817-1-git-send-email-penberg@cs.helsinki.fi> <20100710210750.GC6615@lenovo> In-Reply-To: <20100710210750.GC6615@lenovo> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10/2010 02:07 PM, Cyrill Gorcunov wrote: > On Sat, Jul 10, 2010 at 10:40:20PM +0300, Pekka Enberg wrote: >> This patch adds serial I/O support to very early boot printf(). It's useful for >> debugging boot code when running Linux under KVM, for example. The actual code >> >> +#define cpu_relax() asm volatile("rep; nop" ::: "memory") >> + We don't need "memory" here since the early boot environment is single-threaded. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.