From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix for relocatable PowerPC kernels
Date: Tue, 13 Jul 2010 11:21:28 +0200 [thread overview]
Message-ID: <4C3C3018.3080508@gmail.com> (raw)
In-Reply-To: <20100713054523.GC10155@kryten>
[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]
On 07/13/2010 07:45 AM, Anton Blanchard wrote:
> Hi,
>
> PowerPC Linux kernels can now be built relocatable so we need to check
> for that in the loader.
>
> Anton
>
>
Is building as ET_DYN supported upstream? We previously had reports of
building system of some distros to be plainly borked and usualy the
distro fixed their building system pretty fast. If upstream supports
ET_DYN, then this patch is accepted with no further questions. But if
it's a borked building system it may have subtle bugs and allowing it
would probably just suppress an early symptom of other problems.
> --
>
> 2010-07-13 Anton Blanchard <anton@samba.org>
>
> * loader/powerpc/ieee1275/linux.c (grub_cmd_linux): Do not reject
> ET_DYN files.
>
> Index: grub/loader/powerpc/ieee1275/linux.c
> ===================================================================
> --- grub.orig/loader/powerpc/ieee1275/linux.c 2010-07-11 12:05:16.443242734 +1000
> +++ grub/loader/powerpc/ieee1275/linux.c 2010-07-12 14:56:20.301991065 +1000
> @@ -220,7 +220,7 @@ grub_cmd_linux (grub_command_t cmd __att
> if (! elf)
> goto out;
>
> - if (elf->ehdr.ehdr32.e_type != ET_EXEC)
> + if (elf->ehdr.ehdr32.e_type != ET_EXEC && elf->ehdr.ehdr32.e_type != ET_DYN)
> {
> grub_error (GRUB_ERR_UNKNOWN_OS,
> "this ELF file is not of the right type");
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next parent reply other threads:[~2010-07-13 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100713054523.GC10155@kryten>
2010-07-13 9:21 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2010-07-13 10:12 ` [PATCH] Fix for relocatable PowerPC kernels Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3C3018.3080508@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox