* [PATCH]trivial: clear the comment on parameters for ext2_xattr_set
@ 2010-07-14 0:51 shenghui
0 siblings, 0 replies; 3+ messages in thread
From: shenghui @ 2010-07-14 0:51 UTC (permalink / raw)
To: kernel-janitors, linux-ext4, linux-kernel, error27
Sorry. I changed to another mail client.
Please recheck the patch.
Signed-off-by: Wang Sheng-Hui <crosslonelyover@gmail.com>
---
fs/ext2/xattr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 7c39157..194269e 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -355,7 +355,7 @@ static void ext2_xattr_update_super_block(struct super_block *sb)
/*
* ext2_xattr_set()
*
- * Create, replace or remove an extended attribute for this inode. Buffer
+ * Create, replace or remove an extended attribute for this inode. Value
* is NULL to remove an existing extended attribute, and non-NULL to
* either replace an existing extended attribute, or create a new extended
* attribute. The flags XATTR_REPLACE and XATTR_CREATE
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH]trivial: clear the comment on parameters for ext2_xattr_set
@ 2010-07-13 15:03 Wang Sheng-Hui
2010-07-13 19:24 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Wang Sheng-Hui @ 2010-07-13 15:03 UTC (permalink / raw)
To: kernel-janitors, linux-ext4, linux-kernel
Hi,
The comment for ext2_xattr_get is confusing for it has
no parameter named "buffer". I checked the code and think the
description is suitable for the parameter "value".
Following patch is against 2.6.35-rc5. Please check it.
Signed-off-by: Wang Sheng-Hui <crosslonelyover@gmail.com>
---
fs/ext2/xattr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 5ecbbd8..f56b599 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -355,7 +355,7 @@ static void ext2_xattr_update_super_block(struct
super_block *sb)
/*
* ext2_xattr_set()
*
- * Create, replace or remove an extended attribute for this inode. Buffer
+ * Create, replace or remove an extended attribute for this inode. Value
* is NULL to remove an existing extended attribute, and non-NULL to
* either replace an existing extended attribute, or create a new extended
* attribute. The flags XATTR_REPLACE and XATTR_CREATE
--
1.7.1.1
--
Thanks and Regards,
shenghui
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH]trivial: clear the comment on parameters for ext2_xattr_set
2010-07-13 15:03 Wang Sheng-Hui
@ 2010-07-13 19:24 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-07-13 19:24 UTC (permalink / raw)
To: Wang Sheng-Hui; +Cc: kernel-janitors, linux-ext4, linux-kernel
On Tue, Jul 13, 2010 at 11:03:31PM +0800, Wang Sheng-Hui wrote:
> diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
> index 5ecbbd8..f56b599 100644
> --- a/fs/ext2/xattr.c
> +++ b/fs/ext2/xattr.c
> @@ -355,7 +355,7 @@ static void ext2_xattr_update_super_block(struct
> super_block *sb)
> /*
> * ext2_xattr_set()
> *
> - * Create, replace or remove an extended attribute for this inode. Buffer
> + * Create, replace or remove an extended attribute for this inode. Value
> * is NULL to remove an existing extended attribute, and non-NULL to
It is talking about the "value" parameter, but your email client mangled
this patch so it doesn't apply.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-14 0:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 0:51 [PATCH]trivial: clear the comment on parameters for ext2_xattr_set shenghui
-- strict thread matches above, loose matches on Subject: below --
2010-07-13 15:03 Wang Sheng-Hui
2010-07-13 19:24 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox