From: Michal Marek <mmarek@suse.cz>
To: Alexander Shishkin <virtuoso@slind.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
linux-kbuild@vger.kernel.org, "Sebastian Dalfuß" <sd@sedf.de>,
"Oliver Hartkopp" <oliver@hartkopp.net>,
"Michael Guntsche" <mike@it-loops.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Michael Tokarev" <mjt@tls.msk.ru>, "Alek Du" <alek.du@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Russell King" <rmk@arm.linux.org.uk>,
"Albin Tonnerre" <albin.tonnerre@free-electrons.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] implement size_append in perl
Date: Wed, 14 Jul 2010 18:33:11 +0200 [thread overview]
Message-ID: <4C3DE6C7.6040608@suse.cz> (raw)
In-Reply-To: <20100714161201.GD23436@shisha.kicks-ass.net>
On 07/14/2010 06:12 PM, Alexander Shishkin wrote:
> On Wed, Jul 14, 2010 at 07:54:43 -0700, H. Peter Anvin wrote:
>> On 07/14/2010 07:01 AM, Alexander Shishkin wrote:
>>> +size_append = $(PERL) -e 'print pack("V", (stat "$(lastword $1)")[7])'
>>
>> Why the "lastword"?
>
> There's a whitespace right after it due to it being part of the target
> spec "$(obj)/piggy.$(suffix_y) FORCE", where "FORCE" is being filtered
> out.
Then you should use $(strip $1), which is more obvious IMO.
Michal
next prev parent reply other threads:[~2010-07-14 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 14:01 [PATCH] [RFC] implement size_append in perl Alexander Shishkin
2010-07-14 14:54 ` H. Peter Anvin
2010-07-14 16:12 ` Alexander Shishkin
2010-07-14 16:33 ` Michal Marek [this message]
2010-07-14 15:23 ` Sam Ravnborg
2010-07-14 16:17 ` Alexander Shishkin
2010-07-14 16:57 ` H. Peter Anvin
2010-07-14 20:48 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3DE6C7.6040608@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=albin.tonnerre@free-electrons.com \
--cc=alek.du@intel.com \
--cc=hpa@zytor.com \
--cc=jrnieder@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@it-loops.com \
--cc=mjt@tls.msk.ru \
--cc=oliver@hartkopp.net \
--cc=rmk@arm.linux.org.uk \
--cc=sd@sedf.de \
--cc=virtuoso@slind.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox