From: "H. Peter Anvin" <hpa@zytor.com>
To: "Pan, Jacob jun" <jacob.jun.pan@intel.com>
Cc: Ben Greear <greearb@candelatech.com>,
Robert Hancock <hancockrwd@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>
Subject: Re: Regression: 2.6.34 boot fails on E5405 system, bisected: de08e2c26
Date: Wed, 14 Jul 2010 11:25:30 -0700 [thread overview]
Message-ID: <4C3E011A.9060007@zytor.com> (raw)
In-Reply-To: <43F901BD926A4E43B106BF17856F0755EA8EEA18@orsmsx508.amr.corp.intel.com>
On 07/14/2010 11:19 AM, Pan, Jacob jun wrote:
>
> I have not seen the patch yet, but there is no guarantee that
> capabilities are always laid out in ascending address. So I think
> we cannot bail out when
> pcie_cap >> 20 <= pos
>
> If that is some bug in the config space, can we fix it with some quirks?
>
I don't understand where that arithmetic comes from.
Basic config space [0-255] and extended config space [256-4095] are laid
out completely differently, and they have separate capability chains.
In theory one could have extended capabilities in basic config space,
but since the root of that chain is at 0x100, you'd have to have
extended config space available anyway in order to see it.
-hpa
next prev parent reply other threads:[~2010-07-14 18:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 0:36 Regression: 2.6.34 boot fails on E5405 system, bisected: de08e2c26 Ben Greear
2010-07-14 1:17 ` Ben Greear
2010-07-14 1:56 ` Robert Hancock
2010-07-14 2:22 ` Ben Greear
2010-07-14 3:29 ` Robert Hancock
2010-07-14 14:14 ` Ben Greear
2010-07-14 15:36 ` Pan, Jacob jun
2010-07-14 16:09 ` Ben Greear
2010-07-14 16:11 ` Ben Greear
2010-07-14 17:06 ` Ben Greear
2010-07-14 18:19 ` Pan, Jacob jun
2010-07-14 18:22 ` Ben Greear
2010-07-14 18:47 ` H. Peter Anvin
2010-07-14 18:25 ` H. Peter Anvin [this message]
2010-07-14 18:35 ` H. Peter Anvin
2010-07-14 18:41 ` Ben Greear
2010-07-14 2:19 ` Jesse Barnes
2010-07-14 2:24 ` Ben Greear
2010-07-14 18:52 ` H. Peter Anvin
2010-07-14 18:59 ` Jesse Barnes
2010-07-14 19:01 ` Pan, Jacob jun
2010-07-14 19:55 ` H. Peter Anvin
2010-07-15 16:38 ` Ben Greear
2010-07-16 17:33 ` Pan, Jacob jun
2010-07-16 18:28 ` H. Peter Anvin
2010-07-14 19:03 ` H. Peter Anvin
2010-07-14 19:27 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3E011A.9060007@zytor.com \
--to=hpa@zytor.com \
--cc=greearb@candelatech.com \
--cc=hancockrwd@gmail.com \
--cc=jacob.jun.pan@intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox