From: Larry Finger <Larry.Finger@lwfinger.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Bugzilla # 16395: Regression in 2.6.35-rc4 since commit 0b28bac5aef7bd1ab213723df031e61db9ff151a on HP Mini 110 Netbook
Date: Wed, 14 Jul 2010 19:43:57 -0500 [thread overview]
Message-ID: <4C3E59CD.7050901@lwfinger.net> (raw)
In-Reply-To: <201007141707.37234.dmitry.torokhov@gmail.com>
On 07/14/2010 07:07 PM, Dmitry Torokhov wrote:
> On Wednesday, July 14, 2010 04:58:39 pm Larry Finger wrote:
>> Since the commit in the title, a kernel built on an HP Mini 110 Netbook no
>> longer has keyboard input. The main difference is that CONFIG_SERIO_I8042
>> is no longer defined. When this equal yes, the keyboard works. The faulty
>> commit was located by bisection and has been verified by reverting the
>> patch.
>>
>> Further investigation shows that the faulty hunk is
>>
>> diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
>> index 3bfe8fa..256b9e9 100644
>> --- a/drivers/input/serio/Kconfig
>> +++ b/drivers/input/serio/Kconfig
>> @@ -22,7 +22,7 @@ config SERIO_I8042
>> tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
>> default y
>> depends on !PARISC&& (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST)&& \
>> - (!SUPERH || SH_CAYMAN)&& !M68K&& !BLACKFIN
>> + (!SUPERH || SH_CYes, AYMAN)&& !M68K&& !BLACKFIN&&
>> !X86_MRST help
>> i8042 is the chip over which the standard AT keyboard and PS/2
>> mouse are connected to the computer. If you use these devices,
>>
>> Reverting this one hunk alone results in a working system. Obviously, this
>> Netbook does not have X86_MRST set.
>
>
> You meant to say "does have CONFIG_X86_MRST set", right?
Yes. I got lost in the negative logic. Since !X86_MRST is false, then X86_MRST
has to be defined. In fact, .config has CONFIG_X86_MRST=y.
Larry
next prev parent reply other threads:[~2010-07-15 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 23:58 Bugzilla # 16395: Regression in 2.6.35-rc4 since commit 0b28bac5aef7bd1ab213723df031e61db9ff151a on HP Mini 110 Netbook Larry Finger
2010-07-15 0:07 ` Dmitry Torokhov
2010-07-15 0:43 ` Larry Finger [this message]
2010-07-15 1:07 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3E59CD.7050901@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox