* [PATCH 09/11] staging: comedi: formatting of pointers in printk()
@ 2010-07-15 6:42 Kulikov Vasiliy
2010-07-15 6:46 ` Jiri Slaby
0 siblings, 1 reply; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-07-15 6:42 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Dominik Brodowski, Alexander Kurz,
Jiri Kosina, Javier Martinez Canillas, devel, linux-kernel
Use %p instead of %08x in printk().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index 8d16380..8b49cb1 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
for (i = 0; i < len; i++) {
if (i % 16 == 0)
- printk("\n0x%08x:", (unsigned int)cptr);
+ printk("\n%p:", cptr);
printk(" %02x", *(cptr++));
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 09/11] staging: comedi: formatting of pointers in printk()
2010-07-15 6:42 [PATCH 09/11] staging: comedi: formatting of pointers in printk() Kulikov Vasiliy
@ 2010-07-15 6:46 ` Jiri Slaby
2010-07-22 18:45 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Slaby @ 2010-07-15 6:46 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, devel, Javier Martinez Canillas, Jiri Kosina,
Greg Kroah-Hartman, linux-kernel, Dominik Brodowski,
Alexander Kurz
On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index 8d16380..8b49cb1 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
The name and parameters suggest to remove the function completely. (And
use print_hex_dump_bytes instead.)
>
> for (i = 0; i < len; i++) {
> if (i % 16 == 0)
> - printk("\n0x%08x:", (unsigned int)cptr);
> + printk("\n%p:", cptr);
>
> printk(" %02x", *(cptr++));
> }
--
js
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 09/11] staging: comedi: formatting of pointers in printk()
2010-07-15 6:46 ` Jiri Slaby
@ 2010-07-22 18:45 ` Greg KH
2010-07-22 18:51 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2010-07-22 18:45 UTC (permalink / raw)
To: Jiri Slaby
Cc: Kulikov Vasiliy, kernel-janitors, devel, Javier Martinez Canillas,
Jiri Kosina, Greg Kroah-Hartman, linux-kernel, Dominik Brodowski,
Alexander Kurz
On Thu, Jul 15, 2010 at 08:46:29AM +0200, Jiri Slaby wrote:
> On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote:
> > Use %p instead of %08x in printk().
> >
> > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> > ---
> > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> > index 8d16380..8b49cb1 100644
> > --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> > +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> > @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
>
> The name and parameters suggest to remove the function completely. (And
> use print_hex_dump_bytes instead.)
I agree, Kulikov, can you make that chagne instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 09/11] staging: comedi: formatting of pointers in printk()
2010-07-22 18:45 ` Greg KH
@ 2010-07-22 18:51 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-07-22 18:51 UTC (permalink / raw)
To: Greg KH
Cc: Jiri Slaby, Kulikov Vasiliy, kernel-janitors, devel,
Javier Martinez Canillas, Jiri Kosina, Greg Kroah-Hartman,
linux-kernel, Dominik Brodowski, Alexander Kurz
On Thu, 2010-07-22 at 11:45 -0700, Greg KH wrote:
> On Thu, Jul 15, 2010 at 08:46:29AM +0200, Jiri Slaby wrote:
> > On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote:
> > The name and parameters suggest to remove the function completely. (And
> > use print_hex_dump_bytes instead.)
> I agree, Kulikov, can you make that chagne instead?
The function isn't used at all and should simply be removed.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-22 18:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-15 6:42 [PATCH 09/11] staging: comedi: formatting of pointers in printk() Kulikov Vasiliy
2010-07-15 6:46 ` Jiri Slaby
2010-07-22 18:45 ` Greg KH
2010-07-22 18:51 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).