From: Yinghai Lu <yinghai@kernel.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Don Zickus <dzickus@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
stable <stable@kernel.org>
Subject: Re: [PATCH] x86: fix x2apic preenabled system with kexec
Date: Thu, 15 Jul 2010 13:10:37 -0700 [thread overview]
Message-ID: <4C3F6B3D.7030303@kernel.org> (raw)
In-Reply-To: <1279217784.2751.7.camel@sbs-t61.sc.intel.com>
On 07/15/2010 11:16 AM, Suresh Siddha wrote:
> On Thu, 2010-07-15 at 00:00 -0700, Yinghai Lu wrote:
>
>> BTW: is there any x2apic preenabled system with apicid of boot cpu > 255?
>
> I am not sure. There might be one. Is there any bug which can't handle
> this condition?
We merged apic_ops into struct apic a while ago.
so even for system with x2apic preenabled by BIOS, x2apic_cluster/phys is set to apic until smp_pare_cpus()::default_setup_apic_routing() after enable_IR_x2apic.
that means the boot cpu x2apic is accessed via memmap instead msr based way at that point.
not sure if the Boot apic id is bigger than 255. read_apic() for apic id could be wrong. ( in early_acpi_boot_init, acpi_boot_init, init_apic_mappings)
looks like we need to re-read boot_cpu_physical_apicid
or we could assign x2apic_cluster/phys in check_x2apic(), and later if intr_remapping can not be enabed, we can revert back to phys_flat or flat?
Thanks
Yinghai Lu
next prev parent reply other threads:[~2010-07-15 20:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 2:59 tip/master broken with x2apic and kexec Yinghai Lu
2010-07-13 3:29 ` Yinghai Lu
2010-07-13 6:40 ` H. Peter Anvin
2010-07-14 0:54 ` [tip:x86/alternatives] x86, alternatives: Fix one more open-coded 8-bit alternative number tip-bot for H. Peter Anvin
2010-07-14 0:54 ` [tip:x86/alternatives] x86, alternatives: BUG on encountering an invalid CPU feature number tip-bot for H. Peter Anvin
2010-07-13 22:00 ` tip/master broken with x2apic and kexec H. Peter Anvin
2010-07-13 23:27 ` Yinghai Lu
2010-07-14 20:35 ` Yinghai Lu
2010-07-14 21:05 ` Don Zickus
2010-07-14 22:07 ` Yinghai Lu
2010-07-14 21:23 ` Yinghai Lu
2010-07-14 22:57 ` Yinghai Lu
2010-07-15 0:03 ` Suresh Siddha
2010-07-15 2:01 ` Yinghai Lu
2010-07-15 7:00 ` [PATCH] x86: fix x2apic preenabled system with kexec Yinghai Lu
2010-07-15 18:16 ` Suresh Siddha
2010-07-15 20:10 ` Yinghai Lu [this message]
2010-07-15 20:40 ` Yinghai Lu
2010-07-17 0:48 ` [tip:x86/urgent] x86: Fix " tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3F6B3D.7030303@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).