From: Jeff Garzik <jeff@garzik.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Peter Huewe" <PeterHuewe@gmx.de>,
"Kernel Janitors" <kernel-janitors@vger.kernel.org>,
"Jens Axboe" <jens.axboe@oracle.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Márton Németh" <nm127@freemail.hu>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Date: Thu, 15 Jul 2010 20:51:19 -0400 [thread overview]
Message-ID: <4C3FAD07.6040104@garzik.org> (raw)
In-Reply-To: <20100715185904.GA4023@x200>
On 07/15/2010 03:03 PM, Alexey Dobriyan wrote:
> On Thu, Jul 15, 2010 at 08:51:17PM +0200, Peter Huewe wrote:
>> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
>> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
>> PCI_VDEVICE macro, and thus improves readability.
>
> Well, it doesn't improve readability, and ## usage prevents grepping and
> long term plan to switch to numbers instead of PCI_VENDOR_ID_*,
> but whatever.
>
>> - { PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
>> - { PCI_VENDOR_ID_PROMISE, 0x8002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
>> + { PCI_VDEVICE(PROMISE, 0x8000), },
>> + { PCI_VDEVICE(PROMISE, 0x8002), },
Switching to use hex numbers for _device ids_ is encouraged, because
history has proven its pointless to create named constants for
single-use ids. However, using named constants for PCI vendor ids makes
a lot of sense.
Jeff
prev parent reply other threads:[~2010-07-16 0:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:51 [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Peter Huewe
2010-07-15 19:03 ` Alexey Dobriyan
2010-07-16 0:51 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3FAD07.6040104@garzik.org \
--to=jeff@garzik.org \
--cc=PeterHuewe@gmx.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox