From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/4] KVM: MMU: track dirty page in speculative path properly
Date: Fri, 16 Jul 2010 09:58:56 +0800 [thread overview]
Message-ID: <4C3FBCE0.3030402@cn.fujitsu.com> (raw)
In-Reply-To: <20100715164048.GA6980@amt.cnet>
Marcelo Tosatti wrote:
>> It uses access bit to track both page accessed and page dirty, and it's rather cheap...
>
> Xiao,
>
> I don't understand it. What are you trying to achieve?
>
Marcelo,
The issue which we try to fix in this patch is we mark the page dirty in speculative
path, i'm not sure that after Lai's patch this bug is gone, if it's true, this patch
is not needed anymore, otherwise the later patch is the cheaper way help us to fix this
issue.
In the later patch, we use pte.a to track whether the speculative mapping is accessed,
if it's accessed, we mark the page dirty, just like tracking page-accessed.
next prev parent reply other threads:[~2010-07-16 2:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 9:42 [PATCH 1/4] KVM: MMU: fix forgot reserved bits check in speculative path Xiao Guangrong
2010-07-13 9:43 ` [PATCH 2/4] KVM: MMU: cleanup spte update path Xiao Guangrong
2010-07-13 9:45 ` [PATCH 3/4] KVM: MMU: track dirty page in speculative path properly Xiao Guangrong
2010-07-13 22:05 ` Marcelo Tosatti
2010-07-14 1:24 ` Xiao Guangrong
2010-07-14 11:09 ` Marcelo Tosatti
2010-07-14 13:18 ` Xiao Guangrong
2010-07-14 14:06 ` Marcelo Tosatti
2010-07-14 14:25 ` Avi Kivity
2010-07-15 7:44 ` Xiao Guangrong
2010-07-15 16:40 ` Marcelo Tosatti
2010-07-16 1:58 ` Xiao Guangrong [this message]
2010-07-14 5:53 ` Xiao Guangrong
2010-07-13 9:46 ` [PATCH 4/4] KVM: MMU: remove valueless output message Xiao Guangrong
2010-07-13 21:28 ` [PATCH 1/4] KVM: MMU: fix forgot reserved bits check in speculative path Marcelo Tosatti
2010-07-14 1:08 ` Xiao Guangrong
2010-07-14 13:06 ` Avi Kivity
2010-07-14 13:24 ` Xiao Guangrong
2010-07-14 14:27 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3FBCE0.3030402@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox