From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: [PATCH v2 4/6] KVM: MMU: don't atomicly set spte if it's not present
Date: Fri, 16 Jul 2010 11:27:10 +0800 [thread overview]
Message-ID: <4C3FD18E.1010908@cn.fujitsu.com> (raw)
In-Reply-To: <4C3FD11D.1060104@cn.fujitsu.com>
If the old mapping is not present, the spte.a is not lost, so no need
atomic operation to set it
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
arch/x86/kvm/mmu.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index b3896bf..4123e8e 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -307,9 +307,10 @@ static void update_spte(u64 *sptep, u64 new_spte)
{
u64 old_spte;
- if (!shadow_accessed_mask || (new_spte & shadow_accessed_mask)) {
+ if (!shadow_accessed_mask || (new_spte & shadow_accessed_mask) ||
+ !is_rmap_spte(*sptep))
__set_spte(sptep, new_spte);
- } else {
+ else {
old_spte = __xchg_spte(sptep, new_spte);
if (old_spte & shadow_accessed_mask)
mark_page_accessed(pfn_to_page(spte_to_pfn(old_spte)));
--
1.6.1.2
next prev parent reply other threads:[~2010-07-16 3:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 3:19 [PATCH v2 1/6] KVM: MMU: fix forgot reserved bits check in speculative path Xiao Guangrong
2010-07-16 3:23 ` [PATCH v2 2/6] KVM: MMU: fix page accessed tracking lost if ept is enabled Xiao Guangrong
2010-07-16 3:25 ` [PATCH v2 3/6] KVM: MMU: fix page dirty tracking lost while sync page Xiao Guangrong
2010-07-16 3:27 ` Xiao Guangrong [this message]
2010-07-21 18:34 ` Avi Kivity
2010-07-22 1:17 ` Xiao Guangrong
2010-07-16 3:28 ` [PATCH v2 5/6] KVM: MMU: cleanup spte set and accssed/dirty tracking Xiao Guangrong
2010-07-16 3:30 ` [PATCH v2 6/6] KVM: MMU: using __xchg_spte more smarter Xiao Guangrong
2010-07-21 0:36 ` [PATCH v2 1/6] KVM: MMU: fix forgot reserved bits check in speculative path Xiao Guangrong
2010-07-21 18:39 ` Avi Kivity
2010-07-22 1:18 ` Xiao Guangrong
2010-07-25 8:46 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3FD18E.1010908@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox