From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org, Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH 5/6] kvm, x86: use ro page and don't copy shared page
Date: Sun, 18 Jul 2010 18:31:18 +0300 [thread overview]
Message-ID: <4C431E46.3010001@redhat.com> (raw)
In-Reply-To: <20100718152321.GA20355@redhat.com>
On 07/18/2010 06:23 PM, Gleb Natapov wrote:
> On Sun, Jul 18, 2010 at 06:14:11PM +0300, Avi Kivity wrote:
>
>> On 07/17/2010 07:31 AM, Gleb Natapov wrote:
>>
>>>>> Currently pages allocated for guest memory are required to be RW, so after your series
>>>>> behaviour will remain exactly the same as before.
>>>>>
>>>> Except KSM pages.
>>>>
>>>>
>>> KSM page will be COWed by __get_user_pages_fast(addr, 1, 1, page) in
>>> get_user_page_and_protection() just like it COWed now, no?
>>>
>> Well, we don't want to COW it on write faults.
>>
I meant read faults here.
>> The optimal behaviour is:
>>
>> - write faults: COW and instantiate a writeable spte
>>
> So do we or don't we want to COW on write faults?
>
We do (no choice).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-07-18 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 2:13 [PATCH 5/6] kvm, x86: use ro page and don't copy shared page Lai Jiangshan
2010-07-16 7:19 ` Gleb Natapov
2010-07-16 23:26 ` Marcelo Tosatti
2010-07-17 4:31 ` Gleb Natapov
2010-07-18 15:14 ` Avi Kivity
2010-07-18 15:23 ` Gleb Natapov
2010-07-18 15:31 ` Avi Kivity [this message]
2010-07-29 2:19 ` Lai Jiangshan
2010-07-29 2:15 ` Lai Jiangshan
2010-07-29 5:56 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C431E46.3010001@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox